From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: Re: ddns patches for desec.io provider support Date: Mon, 31 Aug 2015 17:37:44 +0100 Message-ID: <1441039064.18358.123.camel@ipfire.org> In-Reply-To: <55E47CA5.6040804@desec.io> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5147468169370874273==" List-Id: --===============5147468169370874273== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Hi Jonas, thank you for taking the time. This patch looks good to me. Acked-By: Michael Tremer On Mon, 2015-08-31 at 18:11 +0200, Jonas wrote: > Hi, > > > sorry for the delay. The desec.io DDNS provider > class is now implemented analog to > > http://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/providers.py;h=6a > c5 > 56444553fbf0d6e8b23854fe228ad6c81fc5;hb=HEAD#l805 > > for simultaneous IPv4/v6 updates as suggested by Michael. > > Registering IPv4 and IPv6 addresses with the update.dedyn.io > server was successfully tested. Explicit unregistering will > still require updates on the server side. Most of the providers don't implement that and that is okay. > Find attached the patches for src/ddns/providers.py > and ddns.conf.sample Stefan, would you please merge these patches after giving them good testing? @Jonas: If you want to promote out little ddns client, it will run on other systems as well, not just IPFire. Maybe it needs some slight modification on the one or the other distribution, but I think it is de finitely worth being more widely used. Best, -Michael > > > -Jonas > > > On 07/31/2015 12:09 PM, Michael Tremer wrote: > > Hi, > > > > On Fri, 2015-07-31 at 01:51 +0200, Jonas wrote: > > > Hello Michael, > > > > > > > > > in case of both IPv4 and IPv6 connection, the > > > query string in the update URL may contain > > > both a "myip" and a "myipv6" key simultaneously. > > > (for single protocol updates, "myip" may be used > > > for either protocol) > > That is actually a good idea to do, but that is not included in the > > reference documentation of the DynDNS protocol. > > > > We have implemented this for an other provider so you can simply > > copy > > those two lines and you are done: > > > > http://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/providers.py;h= > > 6ac5 > > 56444553fbf0d6e8b23854fe228ad6c81fc5;hb=HEAD#l805 > > > > > As far as i understand the ddns sources, simultaneous > > > updates are not possible. > > They are. Just like the example above or this: > > > > http://git.ipfire.org/?p=ddns.git;a=blob;f=src/ddns/providers.py;h= > > 6ac5 > > 56444553fbf0d6e8b23854fe228ad6c81fc5;hb=HEAD#l1085 > > > > Most providers just require sending two requests which is not the > > most > > preferable option, but what can you do?! > > > > > This may be resolved on the server side in the future. > > What is probably quite important is to properly clear any IPv4 or > > IPv6 > > addresses when a system does not have connectivity to either one > > any > > more. > > > > > A possible workaround could be to always include > > > both addresses in the update URL, independent of > > > the "protocol" argument of the update method. > > Will you send me an updated patch then? > > > > -Michael > > > > > Kind regards, > > > Jonas > > > > > > On 07/30/2015 01:00 PM, Michael Tremer wrote: > > > > Hello Jonas, > > > > > > > > thank you very much for sending in this patch. It looks really > > > > good. > > > > > > > > I was just wondering if it wouldn't be better to implement IPv6 > > > > support > > > > properly. As far as I understand it, ddns will send two updates > > > > and > > > > the > > > > second one will delete the updated data from the first one. In > > > > case > > > > of > > > > a system having connectivity to the IPv6 and IPv4 Internet, the > > > > DNS > > > > record will just point to the IPv4 address. Correct me if I am > > > > wrong > > > > here. Now it only works if a system has either IPv6 or IPv4 > > > > connectivity. > > > > > > > > Let me know if we can solve this problem. > > > > > > > > Best, > > > > -Michael > > > > > > > > > > > > On Wed, 2015-07-29 at 20:13 +0200, Jonas wrote: > > > > > Hi, > > > > > > > > > > > > > > > i'd like to add support for the desec.io > > > > > dyndns service. > > > > > > > > > > It is DynDNS 2 compatible, so the patch is small. > > > > > > > > > > > > > > > > > > > > Regards, > > > > > Jonas > --===============5147468169370874273== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjEKCmlRSWNCQUFC Q2dBR0JRSlY1SUxZQUFvSkVJQjU4UDl2a0FrSDhoTVFBSUFHRWhvR3FtYTN3OWVweEJlaGFaZE4K Y3FBMDZQSW5KRFJPdU5ENlhFeXQ4NVE5SjcxVVg1a0dXeXlUYUpONU13aDArSVVGa1J5eEhoWHZv OTlKWUpRYgpGWXBCck5pYVJwRlFsUytSOWRKay9nd1JyRFdqMVNIZ3dHTFNjY1ZidVdyUGFFcmhz N0VMSENPSEpwSVdXMzdECi9PWHlYVWZwYng2WW5XdUxibHJyWUVJNFB1QWFzM3dJZ1A1TWRkeWFW OUxxZEJGbnM2WklFaWZCTGdjYWdYMkUKSmlwVkhaOEU5Y2RwU2VzeWhjZTZwT1BhT3Y3aHdTbDNH RnQ3UlJMNU1JZnYxTUk2WjZpSyt6TFR6Ty9ZODkrSgp3MStwd0FscVBUN3dzclNONWtzZFQ5K2sz clJMR0ZPK0VaTElVR0dpekIvb0N5aWsrTE8xV21wMHhJdFQ3djU3Clh5eGgyWnA1VkIzRlVnb3FE dFErTDRzTlVYN2k0bzhzRG9vTm4za3gxMGJvYm10Z3ZsS1JiL0I0eTVKekxyVTIKa2dpYUxTUGtP T2l0TGpMZnRISzVzSmFmMS9qS3ZGZVd4S2hERGh6Y2srb1dFRld0WllJSVFLSFQ2U0hsWXNUMQpZ a29ZeG83SE1ZVVFZbk5MaEJNbk1kL2VtMXRYWkNiTWtJZlZjWE5zSVhYNFkzN24yak9qZGREdXYz OVhPT1MyCnNFTkg5dFJmSjV5VDN1aWZEbytVWnN5bjBTM3lPUTlaL2ZSaDZ1eldFczROcEFoTGRZ djMza1VNT0IyTlpuSW4KaURIU1JXVHBQMUJwbFZFQWpjR29KYmNXV2ExQUdpTFBlODdkYnNGSjUy TFNiVERjVExFakRyY05ybFYwVy9YRwpyOTlDYnVmZW5PUHVBY1BFZEMxYgo9dTlISAotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============5147468169370874273==--