From: Stefan Schantl <stefan.schantl@ipfire.org>
To: ddns@lists.ipfire.org
Subject: [PATCH] Zoneedit: Provide better error message on error 702 responses.
Date: Fri, 29 Apr 2016 13:53:02 +0200 [thread overview]
Message-ID: <1461930782-25457-1-git-send-email-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
A returned error code 702 when using Zoneedit as provider now raise
a request error with an corresponding message instead of a simple
InternalServerError exception.
This will help to clarify and debug update problems.
Fixes #11042.
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
src/ddns/providers.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index 3845193..dbe9261 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
elif output.startswith("<ERROR CODE=\"704\""):
raise DDNSRequestError(_("No valid FQDN was given."))
elif output.startswith("<ERROR CODE=\"702\""):
- raise DDNSInternalServerError
+ raise DDNSRequestError(_("Too frequent update requests have been sent."))
# If we got here, some other update error happened.
raise DDNSUpdateError
--
2.5.5
next reply other threads:[~2016-04-29 11:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-29 11:53 Stefan Schantl [this message]
2016-04-29 12:06 ` Michael Tremer
2016-04-29 12:32 ` Stefan Schantl
2016-04-29 12:35 ` [PATCHv2] " Stefan Schantl
2016-04-29 12:36 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461930782-25457-1-git-send-email-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=ddns@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox