From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject:
 Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.
Date: Fri, 29 Apr 2016 13:06:22 +0100
Message-ID: <1461931582.10266.254.camel@ipfire.org>
In-Reply-To: <1461930782-25457-1-git-send-email-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2805402539935673061=="
List-Id: <ddns.lists.ipfire.org>

--===============2805402539935673061==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

you are introducing whitespace errors there by using spaces instead of tabs.

-Michael

P.S. You can also send this patch to both mailing lists at the same time by
using Cc.

On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> A returned error code 702 when using Zoneedit as provider now raise
> a request error with an corresponding message instead of a simple
> InternalServerError exception.
>=20
> This will help to clarify and debug update problems.
>=20
> Fixes #11042.
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> =C2=A0src/ddns/providers.py | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 3845193..dbe9261 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> =C2=A0		elif output.startswith("<ERROR CODE=3D\"704\""):
> =C2=A0			raise DDNSRequestError(_("No valid FQDN was
> given."))=C2=A0
> =C2=A0		elif output.startswith("<ERROR CODE=3D\"702\""):
> -			raise DDNSInternalServerError
> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0raise=
 DDNSRequestError(_("Too frequent update
> requests have been sent."))
> =C2=A0
> =C2=A0		# If we got here, some other update error happened.
> =C2=A0		raise DDNSUpdateError

--===============2805402539935673061==
Content-Type: application/pgp-signature
Content-Transfer-Encoding: base64
Content-Disposition: attachment; filename="signature.asc"
MIME-Version: 1.0

LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC
Q2dBR0JRSlhJMDQvQUFvSkVJQjU4UDl2a0FrSHVRb1FBSW9iNDQ4WkFCR2I5aVNjd25tQkJTWlQK
WXdpNEdDVXhwY25jUGIyT3AwS1orMjc5UGZ0U0Rib3BrUmxsTDNURTcyTTRERFpIWWo4ODNaNXJY
UkpQK1Jxdwp5TTdyVUpXWHo5THlMd21VZGY0UG4xei8rRDNiNVNGTGFWbDJJSXNNQ2pzMER5YzlZ
QzNqcWRmUnVHVkh0blk1CjkxTUxlOGVSTVZZMkM4RUJrQ0RLcmxXUkZzdmZmMjVyUCsrM0pxeWxn
Q3FoR2wrazgzWnN4WDF6Znk3L093d0sKYmcwR2I2dzN0MHZNRmtXWWNUTktWVG53bEdwSlJIank1
aE96VjRZQzZFZXEwcmZvU05yKzNPNmtXb1U2SFgragpjQUpVbkMvb3BYQlVjZEQrV2ZXWThOQkVC
K0NLcVVhQ1FYOWQrbENqdlI4QmVQV1NQYjAwMW1WOEV6NDBSRk0rCnA0WUV3VkltaVhnMGtXUmJt
WGp4UjJPQkFydEZCL3R4SnpHa3dEb1Fvb3FQNkFVOXBrM2plMHAwdzNBcFBmZ0kKS09pbUNhTGJx
TDh4VUpsOVN2eHdFOUhtK3pocVZXUmIrK0hUUW1kdTRXN201VFZYaUtZOTlRbDFiQ0hLQ200Zwor
L1lxWjR3ZGp3R3BNcjFySU9sQWR6b1dUYmNrSWI2d3JUYUprWVo0TlNxRHorSDBFakU4ZDkxeFZS
Z0xiTDNSCmhNRnJwY1N2SFpsaS9WcUhWb1gySUJSbGYyU0QrMWJYZ3pSZWtWREVYQlRWNWdXSWdB
ODZEd04zZk54SE9tSVkKSXRKdW5sdlJDSHVDeklUcGdySnM4SlQrN2Q2V2E1UmFTK2ZXQms1K0ta
TmhxbVhpVERiSC9zK1gwY0xnQTdTYQpXYm0zVVJSazFsOGVKRzBXOVFhNwo9b0FXKwotLS0tLUVO
RCBQR1AgU0lHTkFUVVJFLS0tLS0K

--===============2805402539935673061==--