From mboxrd@z Thu Jan  1 00:00:00 1970
From: Stefan Schantl <stefan.schantl@ipfire.org>
To: ddns@lists.ipfire.org
Subject:
 Re: [PATCH] Zoneedit: Provide better error message on error 702 responses.
Date: Fri, 29 Apr 2016 14:32:40 +0200
Message-ID: <1461933160.23498.2.camel@ipfire.org>
In-Reply-To: <1461931582.10266.254.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3093091991712684872=="
List-Id: <ddns.lists.ipfire.org>

--===============3093091991712684872==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Thanks for reviewing,

I really don't know why this happened. It seems my vim is miss-
configured and translates tabs into spaces. When using nano as
editor everything works fine....

I'll fix this issue and send a new patch.

-Stefan
> Hi,
>=20
> you are introducing whitespace errors there by using spaces instead
> of tabs.
>=20
> -Michael
>=20
> P.S. You can also send this patch to both mailing lists at the same
> time by
> using Cc.
>=20
> On Fri, 2016-04-29 at 13:53 +0200, Stefan Schantl wrote:
> >=20
> > A returned error code 702 when using Zoneedit as provider now raise
> > a request error with an corresponding message instead of a simple
> > InternalServerError exception.
> >=20
> > This will help to clarify and debug update problems.
> >=20
> > Fixes #11042.
> >=20
> > Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> > ---
> > =C2=A0src/ddns/providers.py | 2 +-
> > =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
> >=20
> > diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> > index 3845193..dbe9261 100644
> > --- a/src/ddns/providers.py
> > +++ b/src/ddns/providers.py
> > @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider):
> > =C2=A0		elif output.startswith("<ERROR CODE=3D\"704\""):
> > =C2=A0			raise DDNSRequestError(_("No valid FQDN
> > was
> > given."))=C2=A0
> > =C2=A0		elif output.startswith("<ERROR CODE=3D\"702\""):
> > -			raise DDNSInternalServerError
> > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0raise=
 DDNSRequestError(_("Too frequent
> > update
> > requests have been sent."))
> > =C2=A0
> > =C2=A0		# If we got here, some other update error
> > happened.
> > =C2=A0		raise DDNSUpdateError

--===============3093091991712684872==--