From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: Re: [PATCHv2] Zoneedit: Provide better error message on error 702 responses. Date: Fri, 29 Apr 2016 13:36:25 +0100 Message-ID: <1461933385.10266.256.camel@ipfire.org> In-Reply-To: <1461933302-24640-1-git-send-email-stefan.schantl@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7874344319292777665==" List-Id: --===============7874344319292777665== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Reviewed-by: Michael Tremer ACK On Fri, 2016-04-29 at 14:35 +0200, Stefan Schantl wrote: > A returned error code 702 when using Zoneedit as provider now raise > a request error with an corresponding message instead of a simple > InternalServerError exception. > > This will help to clarify and debug update problems. > > Fixes #11042. > > Signed-off-by: Stefan Schantl > --- >  src/ddns/providers.py | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index 3845193..c653aa5 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -1576,7 +1576,7 @@ class DDNSProviderZoneedit(DDNSProvider): >   elif output.startswith("   raise DDNSRequestError(_("No valid FQDN was > given."))  >   elif output.startswith(" - raise DDNSInternalServerError > + raise DDNSRequestError(_("Too frequent update > requests have been sent.")) >   >   # If we got here, some other update error happened. >   raise DDNSUpdateError --===============7874344319292777665== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC Q2dBR0JRSlhJMVZKQUFvSkVJQjU4UDl2a0FrSHJJTVAvM1lHNm14aGZGREJ1NnRJVUUra0FOZEYK MTBuTVlPNUVtSGJ3U013NDV4dEZJUVdJRGh6Q2lyYkpaTEd5Z05FSjJZUDlBNlZMa3FpVGJOWmdz RHlzTSsrRQpBN3c4bEJuWVUwOHEvZ1lLeENPN0pQZVFGc2lhUTE2WEhLTGNHYTMwZHMyNGFjNFBZ ekxsSmtKR1Y4R0RHajVGCnVlSjdFMmswZkRNYnpoTis3LzlzTWJYSS9ZZmJZSVduMWNZbEpGTkkv ZG1UQ2l6MjFFYnQ5azk0c2I5eC9EYlEKcHUrQSs0Yy9qRFZwMmJkeE5YRDRMTjdTaXFJMGZJRldt eGtsTlhkaHk1M21rRU1KaFpMRUxnOXh5OWk1U0RTVApFOGZiQXZNSFQwUHQvZXBrQW9kL1ZYVnhN TDRSSkd4a2Y1VDFnTGNnT2h6Z0pYQmd0dFNHeXM0UEZiZ2FFcis5CkJ3U2R5KzEvTDRDRTRGU3Bl clozMjZTR0d0aEI2eVdKQVllZUQyWXJWU3g4aDdaUUd1VkdLUXpOQW95Mk9Cc0sKS2R5Rk84U1dT QTRVelNFcUpHYUJ1MjFXQXYwMkJmM1VMVVUwaXd5UnAyN3RoOEYwZmlKbkFPMnNTeW5DUDIycApx S1JNbGNuTGMxdGgyS08wQ05acnNOY00rT2FDV3pNRlBBaGphMGhReldyd1E5MnE0KzkyZDFkSjZ4 WjlJQlgyCm5RS3gwRHJqU1dUWStBcmk1UnpyY0hXSitwVGt1WEdCYmhUbFFrL3FFcXkvR2E2b1Np UnRhVjNGMGkzaysveEkKUEVWMi9uN0lqN2tZQnI2YkJLVlFKN01LRU9hWDZJSHFINFJ3czRYMG1M TWIvdXFxZUwzRkdFTWxidkxyc1UzSwp1SzVzVDdnVGxvYi9OWW1mbi9vWgo9eTVKbwotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============7874344319292777665==--