Re: [PATCH 1/2] ddns: Import patch for schokokeks.org support.

Re: [PATCH 1/2] ddns: Import patch for schokokeks.org support.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3217 bytes --]

Hi,

I did not see this patch going through the normal mailing list process.

However, I have a comment that I will post here instead.

On Fri, 2016-09-30 at 10:56 +0200, Stefan Schantl wrote:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  lfs/ddns                                           |  2 +
>  .../ddns-0001-New-provider-Schokokeks.org.patch    | 47
> ++++++++++++++++++++++
>  2 files changed, 49 insertions(+)
>  create mode 100644 src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> 
> diff --git a/lfs/ddns b/lfs/ddns
> index 422f8e3..90c70c6 100644
> --- a/lfs/ddns
> +++ b/lfs/ddns
> @@ -71,6 +71,8 @@ $(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
>  	@$(PREBUILD)
>  	@rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
>  
> +	cd $(DIR_APP) && patch -Np1 -i $(DIR_SRC)/src/patches/ddns-0001-New-
> provider-Schokokeks.org.patch
> +
>  	cd $(DIR_APP) && [ -x "configure" ] || sh ./autogen.sh
>  	cd $(DIR_APP) && ./configure \
>  		--prefix=/usr \
> diff --git a/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> new file mode 100644
> index 0000000..be123a5
> --- /dev/null
> +++ b/src/patches/ddns-0001-New-provider-Schokokeks.org.patch
> @@ -0,0 +1,47 @@
> +From 521c9d90f4e879ef3d9e1590f29e27990011ae46 Mon Sep 17 00:00:00 2001
> +From: Steffen Peters <sauron99(a)gmx.de>
> +Date: Mon, 4 Jul 2016 22:14:10 +0200
> +Subject: [PATCH 185/185] New provider: Schokokeks.org
> +
> +Signed-off-by: Steffen Peters <sauron99(a)gmx.de>
> +Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> +---
> + README                |  1 +
> + src/ddns/providers.py | 12 ++++++++++++
> + 2 files changed, 13 insertions(+)
> +
> +diff --git a/README b/README
> +index d8027a4..cedbf21 100644
> +--- a/README
> ++++ b/README
> +@@ -75,6 +75,7 @@ SUPPORTED PROVIDERS:
> + 	opendns.com
> + 	ovh.com
> + 	regfish.com
> ++	schokokeks.org
> + 	selfhost.de
> + 	spdns.org
> + 	strato.com
> +diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> +index 6b25cb6..c482dad 100644
> +--- a/src/ddns/providers.py
> ++++ b/src/ddns/providers.py
> +@@ -1687,3 +1687,15 @@ class DDNSProviderZZZZ(DDNSProvider):
> + 
> + 		# If we got here, some other update error happened.
> + 		raise DDNSUpdateError
> ++
> ++class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
> ++       handle    = "schokokeks.org"
> ++       name      = "Schokokeks"
> ++       website   = "http://www.schokokeks.org/"
> ++       protocols = ("ipv4",)
> ++
> ++       # Information about the format of the request is to be found
> ++       # https://wiki.schokokeks.org/DynDNS
> ++
> ++       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>;"
> ++

This URL is clearly malformed and therefore the patch should not have been
accepted. <ipaddr> is just a placeholder here and luckily everything after the ?
is stripped off and replaced by the actual arguments. But that is still stuff
that I do not want to see here.

Best,
-Michael

> +-- 
> +2.7.4
> +

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]