[PATCH] Schockokeks.org: Fix malformed update URL.

[PATCH] Schockokeks.org: Fix malformed update URL.

[Stefan Schantl]

[-- Attachment #1: Type: text/plain, Size: 1500 bytes --]

* Move Provider Class into correct alphabetical order.

Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
 src/ddns/providers.py | 23 +++++++++++------------
 1 file changed, 11 insertions(+), 12 deletions(-)

diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index c482dad..2c30d42 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -1424,6 +1424,17 @@ class DDNSProviderRegfish(DDNSProvider):
 		raise DDNSUpdateError
 
 
+class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
+	handle    = "schokokeks.org"
+	name      = "Schokokeks"
+	website   = "http://www.schokokeks.org/"
+	protocols = ("ipv4",)
+
+	# Information about the format of the request is to be found
+	# https://wiki.schokokeks.org/DynDNS
+	url = "https://dyndns.schokokeks.org/nic/update"
+
+
 class DDNSProviderSelfhost(DDNSProtocolDynDNS2, DDNSProvider):
 	handle    = "selfhost.de"
 	name      = "Selfhost.de"
@@ -1687,15 +1698,3 @@ class DDNSProviderZZZZ(DDNSProvider):
 
 		# If we got here, some other update error happened.
 		raise DDNSUpdateError
-
-class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
-       handle    = "schokokeks.org"
-       name      = "Schokokeks"
-       website   = "http://www.schokokeks.org/"
-       protocols = ("ipv4",)
-
-       # Information about the format of the request is to be found
-       # https://wiki.schokokeks.org/DynDNS
-
-       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>"
-
-- 
2.7.4

Re: [PATCH] Schockokeks.org: Fix malformed update URL.

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1871 bytes --]

Thanks for correcting this.

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

On Fri, 2016-10-28 at 12:35 +0200, Stefan Schantl wrote:
> * Move Provider Class into correct alphabetical order.
> 
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>  src/ddns/providers.py | 23 +++++++++++------------
>  1 file changed, 11 insertions(+), 12 deletions(-)
> 
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index c482dad..2c30d42 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1424,6 +1424,17 @@ class DDNSProviderRegfish(DDNSProvider):
>  		raise DDNSUpdateError
>  
>  
> +class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
> +	handle    = "schokokeks.org"
> +	name      = "Schokokeks"
> +	website   = "http://www.schokokeks.org/"
> +	protocols = ("ipv4",)
> +
> +	# Information about the format of the request is to be found
> +	# https://wiki.schokokeks.org/DynDNS
> +	url = "https://dyndns.schokokeks.org/nic/update"
> +
> +
>  class DDNSProviderSelfhost(DDNSProtocolDynDNS2, DDNSProvider):
>  	handle    = "selfhost.de"
>  	name      = "Selfhost.de"
> @@ -1687,15 +1698,3 @@ class DDNSProviderZZZZ(DDNSProvider):
>  
>  		# If we got here, some other update error happened.
>  		raise DDNSUpdateError
> -
> -class DDNSProviderSchokokeksDNS(DDNSProtocolDynDNS2, DDNSProvider):
> -       handle    = "schokokeks.org"
> -       name      = "Schokokeks"
> -       website   = "http://www.schokokeks.org/"
> -       protocols = ("ipv4",)
> -
> -       # Information about the format of the request is to be found
> -       # https://wiki.schokokeks.org/DynDNS
> -
> -       url = "https://dyndns.schokokeks.org/nic/update?myip=<ipaddr>;"
> -

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]