From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: Re: [PATCH] ddns: fixed compile error Date: Wed, 24 May 2017 15:43:18 +0100 Message-ID: <1495636998.2151.22.camel@ipfire.org> In-Reply-To: <99179154.3066.1494498203022@office.mailbox.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============3264861340597715609==" List-Id: --===============3264861340597715609== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, @Stefan: Could you please review these patches more swiftly? There are so many things open and lying around regarding ddns which I would like to see solved. No need to rush things, but at least I would like to see things moving forwar= d. Best, -Michael On Thu, 2017-05-11 at 12:23 +0200, dirk.wagner(a)ipfire.org wrote: > Sorry for the empty Subject, parts of the mail are lost. >=20 > The patch is for the status-defeated branch >=20 > > ---------- Urspr=C3=BCngliche Nachricht ---------- > > Von: Dirk Wagner > > An: ddns(a)lists.ipfire.org > > Cc: Dirk Wagner > > Datum: 11. Mai 2017 um 12:16 > > Betreff:=C2=A0 > >=20 > > One issue remains: > > The constant holdoff_rate_limited_minutes should be overwritable for each > > provider. For DomainOffensive 30 min ist too short. > >=20 > > From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001 > > From: Dirk Wagner > > Date: Thu, 11 May 2017 09:04:49 +0200 > > Subject: [PATCH] ddns: fixed compile errors > >=20 > > Signed-off-by: Dirk Wagner > > --- > > =C2=A0src/ddns/providers.py | 6 +++--- > > =C2=A01 file changed, 3 insertions(+), 3 deletions(-) > >=20 > > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > > index cb6dd2d..5386f35 100644 > > --- a/src/ddns/providers.py > > +++ b/src/ddns/providers.py > > @@ -69,7 +69,7 @@ class DDNSProvider(object): > > =C2=A0 > > =C2=A0 # holdoff time for rate-limited updates - Number of minutes no > > update > > =C2=A0 # is tried after the last one has been sent. > > - holdoff_rate-limited_minutes =3D 30 > > + holdoff_rate_limited_minutes =3D 30 > > =C2=A0 > > =C2=A0 # True if the provider is able to remove records, too. > > =C2=A0 # Required to remove AAAA records if IPv6 is absent again. > > @@ -248,10 +248,10 @@ class DDNSProvider(object): > > =C2=A0 last_update =3D self.db.last_update(self.hostname, > > status=3Dlast_status) > > =C2=A0 > > =C2=A0 # Calculate holdoff end, based on the last status (failure > > or rate-limited) > > - if last_status =3D=3D "failure" > > + if last_status =3D=3D "failure": > > =C2=A0 holdoff_end =3D last_update + > > datetime.timedelta(days=3Dself.holdoff_failure_days) > > =C2=A0 else: > > - holdoff_end =3D last_update + > > datetime.timedelta(minutes=3Dself.holdoff_rate-limited_minutes) > > + holdoff_end =3D last_update + > > datetime.timedelta(minutes=3Dself.holdoff_rate_limited_minutes) > > =C2=A0 > > =C2=A0 now =3D datetime.datetime.utcnow() > > =C2=A0 if now < holdoff_end: > > --=C2=A0 > > 2.1.4 > >=20 >=20 > _______________________________________________ > ddns mailing list > ddns(a)lists.ipfire.org > http://lists.ipfire.org/mailman/listinfo/ddns --===============3264861340597715609== Content-Type: application/pgp-signature Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="signature.asc" MIME-Version: 1.0 LS0tLS1CRUdJTiBQR1AgU0lHTkFUVVJFLS0tLS0KVmVyc2lvbjogR251UEcgdjIKCmlRSWNCQUFC Q2dBR0JRSlpKWndHQUFvSkVJQjU4UDl2a0FrSHYySVAvMnF1NTVxTVVEb29QTURtYWFkVXhzU2sK c05nY3ZqM0hZcjMrM0RxNjhDTS9nWmppMWVIVXVHajNIeElDRmc5ZStmK05lVzAzSDRsL2FnTjEv STZyMnl2WApmWDd0eEc3VUFNK3o3SVhFdjJ6eGhwaStTcXQyVFNiYUdPQ2RwbmFybUs2T1pxTFVM Z2JDT1NCQ0ZVMG0xZ3Z1Clk0TUZDd1pFeEhTSkFHY2VSN003UkdicFFINHpnd3JIMTI5Y0dPZ05C WGR0d2dLZDgvZStSSjZBakx6Ri9SbFEKQ1ppRFZ0MElnMk02bGFQVHBsTFVwZWVIMjBUcHAvV1g1 d0lpVWcyVGNiN3ZhSFZjLzN4akhmZm5vMnVVUEJFawpTcVdxRDRNa3lCTUNSTDZMVHljcit1NjJO aDdEamVMRGJXblVRY0EwUXNiK1RIbUhPSmxORXArelZzSi9iVzRMCkNqOE93ZVVvTmR5L0ViM2dy TCsyQlFBQ0FKTUdiS3dtVnpkeFJXVkh2TjAzOWJxc241VVpsb21yQ0t1VXFPL2UKeWlJR09kSXpC cUtCdGlmZjFpMWJkS3RrRGg5aFgwOG1xUTVZWHp0b3lFWkdUbnl4Z3hYSlVuekZOZjhyOC93MQpX M0VMUElSdEV5b2I5a2RQVE9UbjRIaVRHMFp2bC9ZUzdYMklkWnh5SWoxSm1XaitITnRGTjJmaFNC NVlwUTcyCjFrRGRlbzJONzd4UEFyRWFCaGlMeFc4Mm9sQXdEaldEVzVCL2JqazU0alNJRHBVNFJH eVphNmJSOGJxbi82MmQKeGtLNnNYUk1YMnZ4M2tzRm43UERxYmNCU0JSUzlzUWJCR3lkRmNYdXNK Vi9XU0MrOWZ0blRoemNXKytXY0JIUwpSL2k4c2h5RGlGZktmVDdIVkVHTQo9WWJWTAotLS0tLUVO RCBQR1AgU0lHTkFUVVJFLS0tLS0K --===============3264861340597715609==--