From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject: [PATCH] Use HTTPS for checkip{6,4}.dns.lightningwirelabs.com
Date: Tue, 08 Oct 2019 08:37:06 +0000 [thread overview]
Message-ID: <20191008083706.5120-1-michael.tremer@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Since we are deploying a HSTS policy for lightningwirelabs.com now,
and we generally only use HTTPS for everything, this patch changes
this for the IP address discovery process, too.
Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
---
src/ddns/system.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/ddns/system.py b/src/ddns/system.py
index 67ea553..b7a51f6 100644
--- a/src/ddns/system.py
+++ b/src/ddns/system.py
@@ -112,9 +112,9 @@ class DDNSSystem(object):
def guess_external_ip_address(self, family, **kwargs):
if family == "ipv6":
- url = "http://checkip6.dns.lightningwirelabs.com"
+ url = "https://checkip6.dns.lightningwirelabs.com"
elif family == "ipv4":
- url = "http://checkip4.dns.lightningwirelabs.com"
+ url = "https://checkip4.dns.lightningwirelabs.com"
else:
raise ValueError("unknown address family")
--
2.20.1
reply other threads:[~2019-10-08 8:37 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008083706.5120-1-michael.tremer@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=ddns@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox