From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: [PATCH 1/2] Lightning Wire Labs: Drop authentication using username/password Date: Thu, 30 Jan 2020 17:38:13 +0000 Message-ID: <20200130173814.9364-1-michael.tremer@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============9157008847188225324==" List-Id: --===============9157008847188225324== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit This is quite dangerous using the main credentials to update DDNS. Hence LWL is dropping this now and only supports authentication using tokens. Signed-off-by: Michael Tremer --- src/ddns/providers.py | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 661fbcc..95f3dd5 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1227,27 +1227,17 @@ class DDNSProviderLightningWireLabs(DDNSProvider): url = "https://dns.lightningwirelabs.com/update" def update(self): + # Raise an error if no auth details are given. + if not self.token: + raise DDNSConfigurationError + data = { "hostname" : self.hostname, + "token" : self.token, "address6" : self.get_address("ipv6", "-"), "address4" : self.get_address("ipv4", "-"), } - # Check if a token has been set. - if self.token: - data["token"] = self.token - - # Check for username and password. - elif self.username and self.password: - data.update({ - "username" : self.username, - "password" : self.password, - }) - - # Raise an error if no auth details are given. - else: - raise DDNSConfigurationError - # Send update to the server. response = self.send_request(self.url, data=data) -- 2.20.1 --===============9157008847188225324==--