From: Stefan Schantl <stefan.schantl@ipfire.org>
To: ddns@lists.ipfire.org
Subject: [PATCH] ProviderDDNSS: Fix unhandled exception on update
Date: Mon, 25 May 2020 18:05:45 +0200 [thread overview]
Message-ID: <20200525160545.3816-1-stefan.schantl@ipfire.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 917 bytes --]
In python > 3.3 the getheader() attribute is not longer part of the
urllib.response response.info() object. It is part of response object
and so directly can be accessed.
Fixes #12328
Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
---
src/ddns/providers.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/ddns/providers.py b/src/ddns/providers.py
index f1fed22..46d8a67 100644
--- a/src/ddns/providers.py
+++ b/src/ddns/providers.py
@@ -642,10 +642,8 @@ class DDNSProviderDDNSS(DDNSProvider):
response = self.send_request(self.url, data=data)
# This provider sends the response code as part of the header.
- header = response.info()
-
# Get status information from the header.
- output = header.getheader('ddnss-response')
+ output = response.getheader('ddnss-response')
# Handle success messages.
if output == "good" or output == "nochg":
--
2.26.1
next reply other threads:[~2020-05-25 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-25 16:05 Stefan Schantl [this message]
2020-05-26 10:11 ` Michael Tremer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525160545.3816-1-stefan.schantl@ipfire.org \
--to=stefan.schantl@ipfire.org \
--cc=ddns@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox