From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject: Re: [PATCH] Add new provider INWX (https://www.inwx.com)
Date: Thu, 19 Sep 2019 08:57:09 -0400
Message-ID: <2498526A-6EDA-464B-B03C-9D9E63252619@ipfire.org>
In-Reply-To: <20190918192528.6366-1-ipfire@starkstromkonsument.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8033233525904938697=="
List-Id: <ddns.lists.ipfire.org>

--===============8033233525904938697==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you for sending this patch, but I am afraid I have a little bit of a pr=
oblem here=E2=80=A6

> On 18 Sep 2019, at 15:25, Alexander Koch <ipfire(a)starkstromkonsument.de> =
wrote:
>=20
> This includes:
>=20
> - inwx.com
> - inwx.de
> - inwx.at
> - inwx.ch
> - inwx.es
>=20
> Signed-off-by: Alexander Koch <ipfire(a)starkstromkonsument.de>
> ---
> README                |  1 +
> configure.ac          |  2 +-
> src/ddns/providers.py | 15 ++++++++++++++-
> 3 files changed, 16 insertions(+), 2 deletions(-)
>=20
> diff --git a/README b/README
> index b0601a0..0f2798e 100644
> --- a/README
> +++ b/README
> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS:
> 	enom.com
> 	entrydns.net
> 	freedns.afraid.org
> +	inwx.com|de|at|ch|es
> 	itsdns.de
> 	joker.com
> 	loopia.se
> diff --git a/configure.ac b/configure.ac
> index 008950d..14bccc0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -21,7 +21,7 @@
> AC_PREREQ([2.64])
>=20
> AC_INIT([ddns],
> -	[011],
> +	[012],
> 	[info(a)ipfire.org],
> 	[ddns],
> 	[http://git.ipfire.org/?p=3Doddments/ddns.git;a=3Dsummary])

You don=E2=80=99t need to increment the version number. That will be done by =
the maintainer when ever it is decided to have a new release.

> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 4ffd8bf..12116e3 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1003,7 +1003,7 @@ class DDNSProviderDynsNet(DDNSProvider):
> 			raise DDNSInternalServerError
>=20
> 		# If we got here, some other update error happened.
> -		raise DDNSUpdateError(_("Server response: %s") % output)=20
> +		raise DDNSUpdateError(_("Server response: %s") % output)
>=20

Whitespace changes like this should not be included in this patch. This could=
 be an extra patch.

> class DDNSProviderEnomCom(DDNSResponseParserXML, DDNSProvider):
> @@ -1129,6 +1129,19 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
> 		raise DDNSUpdateError
>=20
>=20
> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider):
> +		handle    =3D "inwx.com"
> +		name      =3D "INWX"
> +		website   =3D "https://www.inwx.com"
> +		protocols =3D ("ipv6", "ipv4")
> +
> +		# Information about the format of the HTTP request is to be found
> +		# here: https://www.inwx.com/en/nameserver2/dyndns (requires login)
> +		# Notice: The URL is the same for: inwx.com|de|at|ch|es
> +
> +		url =3D "https://dyndns.inwx.com/nic/update"
> +
> +

My problem with this provider is that the documentation is not publicly acces=
sible. Therefore this is not maintainable for everyone who does not have an a=
ccount there. Creating an account with every single ISP is of course not an o=
ption either.

I would be interested to hear what Stefan and others think about this.

Best,
-Michael

> class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider):
> 		handle    =3D "itsdns.de"
> 		name      =3D "it's DNS"
> --=20
> 2.17.1
>=20
> _______________________________________________
> ddns mailing list
> ddns(a)lists.ipfire.org
> https://lists.ipfire.org/mailman/listinfo/ddns


--===============8033233525904938697==--