From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: Re: [PATCH] Add new provider INWX (https://www.inwx.com) Date: Mon, 23 Sep 2019 23:27:19 +0100 Message-ID: <7B72732A-4D36-43A3-9C71-A878058D2ADE@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============4222687698975376645==" List-Id: --===============4222687698975376645== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, > On 20 Sep 2019, at 12:20, Alexander Koch = wrote: >=20 > Hi, >=20 > -------- Original Message -------- > From: Michael Tremer [mailto:michael.tremer(a)ipfire.org] > Sent: Thursday, 19 September 2019, 14:57 CEST > To: Alexander Koch > Cc: ddns(a)lists.ipfire.org > Subject: [PATCH] Add new provider INWX (https://www.inwx.com) >=20 >> Hi, >> Thank you for sending this patch, but I am afraid I have a little bit of a= problem here=E2=80=A6 >>> On 18 Sep 2019, at 15:25, Alexander Koch wrote: >>>=20 >>> This includes: >>>=20 >>> - inwx.com >>> - inwx.de >>> - inwx.at >>> - inwx.ch >>> - inwx.es >>>=20 >>> Signed-off-by: Alexander Koch >>> --- >>> README | 1 + >>> configure.ac | 2 +- >>> src/ddns/providers.py | 15 ++++++++++++++- >>> 3 files changed, 16 insertions(+), 2 deletions(-) >>>=20 >>> diff --git a/README b/README >>> index b0601a0..0f2798e 100644 >>> --- a/README >>> +++ b/README >>> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >>> enom.com >>> entrydns.net >>> freedns.afraid.org >>> + inwx.com|de|at|ch|es >>> itsdns.de >>> joker.com >>> loopia.se >>> diff --git a/configure.ac b/configure.ac >>> index 008950d..14bccc0 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -21,7 +21,7 @@ >>> AC_PREREQ([2.64]) >>>=20 >>> AC_INIT([ddns], >>> - [011], >>> + [012], >>> [info(a)ipfire.org], >>> [ddns], >>> [http://git.ipfire.org/?p=3Doddments/ddns.git;a=3Dsummary]) >> You don=E2=80=99t need to increment the version number. That will be done = by the maintainer when ever it is decided to have a new release. >=20 > Ok. >=20 >>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>> index 4ffd8bf..12116e3 100644 >>> --- a/src/ddns/providers.py >>> +++ b/src/ddns/providers.py >>> @@ -1003,7 +1003,7 @@ class DDNSProviderDynsNet(DDNSProvider): >>> raise DDNSInternalServerError >>>=20 >>> # If we got here, some other update error happened. >>> - raise DDNSUpdateError(_("Server response: %s") % output) >>> + raise DDNSUpdateError(_("Server response: %s") % output) >>>=20 >> Whitespace changes like this should not be included in this patch. This co= uld be an extra patch. >=20 > Ok. My text editor corrected this automatically. I didn't think about it an= y further... >=20 >>> class DDNSProviderEnomCom(DDNSResponseParserXML, DDNSProvider): >>> @@ -1129,6 +1129,19 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >>> raise DDNSUpdateError >>>=20 >>>=20 >>> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >>> + handle =3D "inwx.com" >>> + name =3D "INWX" >>> + website =3D "https://www.inwx.com" >>> + protocols =3D ("ipv6", "ipv4") >>> + >>> + # Information about the format of the HTTP request is to be found >>> + # here: https://www.inwx.com/en/nameserver2/dyndns (requires login) >>> + # Notice: The URL is the same for: inwx.com|de|at|ch|es >>> + >>> + url =3D "https://dyndns.inwx.com/nic/update" >>> + >>> + >> My problem with this provider is that the documentation is not publicly ac= cessible. Therefore this is not maintainable for everyone who does not have a= n account there. Creating an account with every single ISP is of course not a= n option either. >> I would be interested to hear what Stefan and others think about this. >> Best, >> -Michael >=20 > I get your point. I did some research in their KB - without login - but cou= ldn't find an alternative place providing the infos. They use the dyndns2-pro= tocol without any modifications. The only information they provide at the giv= en URL (with login) is the Update-URL: https://dyndns.inwx.com/nic/update?myi= p=3D&myipv6=3D I doubt they will ever change this, unless th= ey move to another protocol ... this would then be reported as a bug by a use= r who has a login and is able to provide further information though. Stefan told me today that we have others were the documentation is not public= ly available. Although I do not understand this - why make this so complicate= d for people who are implementing your API? - I guess we have to accept this = then for the same reasons we accepted the other ones for. Acked-by: Michael Tremer > I've got an alternative idea to solve this. As they (and some other of the = already implemented providers) are using the dyndns2-protocoll without any mo= difications, why not add a specific handle "DynDNS2 misc" to the service-drop= down (or an additional dropdown for the protocol) and a textfield for the Upd= ate-URL on the Web UI and create a unified handle for all dyndns2-providers i= n providers.py. The Update-URL for the dydns2-service can easily be provided = by the user. This would simplify the maintenance of ddns on one side and prov= ide support for more dyndns2-services without any effort on the other side. A= similar approach could be used for other existent/future standardized dyndns= -service-protocolls. >=20 > Please let me know what you think about it. I offer to work on a patch for = the "DynDNS2 misc"-service if you like the idea. This however is not a good idea. It defies one of the most important points o= f building ddns in the first place: We wanted to be able to make changes to every provider, because sometimes thi= ngs change. Some providers have asked us to make changes to the behaviour of = ddns and we were able to do that and roll out the changes immediately across = all IPFire systems. That won=E2=80=99t be possible with the generic service. We neither have the UI, and it is not at all a problem to add a provider that= is 100% compatible with DynDNS. It is literally 5 lines of code. That approa= ch allows us a lot of flexibility for very little work. -Michael >=20 >>> class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >>> handle =3D "itsdns.de" >>> name =3D "it's DNS" >>> --=20 >>> 2.17.1 >>>=20 >>> _______________________________________________ >>> ddns mailing list >>> ddns(a)lists.ipfire.org >>> https://lists.ipfire.org/mailman/listinfo/ddns >=20 > Regards, Alex --===============4222687698975376645==--