From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject: Re: [PATCH] Fixes freedns.afraid.org ddns provider
Date: Fri, 22 Jan 2021 13:03:20 +0000
Message-ID: <98EBC5F5-0843-4722-BA8F-9B07B9364F71@ipfire.org>
In-Reply-To:
 <CAHoP+V_80YMyvMrkfOtCf1e7W8c2WBOAUejOZ+ZvUSTg5f_afQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8459278139107965703=="
List-Id: <ddns.lists.ipfire.org>

--===============8459278139107965703==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Kashif,

Thank you for your email.

If the data argument is no longer required, you should remove it entirely ins=
tead of just commenting it out.

Otherwise this looks good.

Best,
-Michael

> On 22 Jan 2021, at 12:59, Kashif Iftikhar <kashif(a)compulife.com.pk> wrote:
>=20
> ------------------------BEGIN PATCH---------------------------
> From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001
> From: Kashif Iftikhar <kashif(a)compulife.com.pk>
> Date: Fri, 22 Jan 2021 17:33:01 +0500
> Subject: [PATCH 1/1] fixes freedns.afraid.org provider.
>=20
> The URL for syncing had changed and now does not require sending the ip
> with the request.
>=20
> Signed-off-by: Kashif Iftikhar <kashif(a)compulife.com.pk>
> ---
> src/ddns/providers.py | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>=20
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index 56e6620..6feef33 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>=20
>     # No information about the request or response could be found on the ve=
ndor
>     # page. All used values have been collected by testing.
> -    url =3D "https://freedns.afraid.org/dynamic/update.php"
> +    url =3D "https://sync.afraid.org/u/"
>     can_remove_records =3D False
>     supports_token_auth =3D True
>=20
>     def update_protocol(self, proto):
> -        data =3D {
> -            "address" : self.get_address(proto),
> -        }
> +        # data =3D {
> +        #     "address" : self.get_address(proto),
> +        # }
>=20
>         # Add auth token to the update url.
> -        url =3D "%s?%s" % (self.url, self.token)
> +        url =3D "%s%s/" % (self.url, self.token)
>=20
>         # Send update to the server.
> -        response =3D self.send_request(url, data=3Ddata)
> +        response =3D self.send_request(url)
>=20
>         # Get the full response message.
>         output =3D response.read().decode()
>=20
>         # Handle success messages.
> -        if output.startswith("Updated") or "has not changed" in output:
> +        if output.startswith("Updated") or output.startswith("No IP
> change detected"):
>             return
>=20
>         # Handle error codes.
> --
> 2.25.1
>=20
>=20
> ------------------------END PATCH---------------------------
>=20
> Regards.
> Kashif Iftikhar
> http://kashif.compulife.com.pk
> _______________________________________________
> ddns mailing list
> ddns(a)lists.ipfire.org
> https://lists.ipfire.org/mailman/listinfo/ddns


--===============8459278139107965703==--