public inbox for ddns@lists.ipfire.org
 help / color / mirror / Atom feed
From: dirk.wagner@ipfire.org
To: ddns@lists.ipfire.org
Subject: [PATCH] ddns: fixed compile error
Date: Thu, 11 May 2017 12:23:22 +0200	[thread overview]
Message-ID: <99179154.3066.1494498203022@office.mailbox.org> (raw)
In-Reply-To: <1494497813-2694-1-git-send-email-dirk.wagner@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2066 bytes --]

Sorry for the empty Subject, parts of the mail are lost.

The patch is for the status-defeated branch

> ---------- Ursprüngliche Nachricht ----------
> Von: Dirk Wagner <dirk.wagner(a)ipfire.org>
> An: ddns(a)lists.ipfire.org
> Cc: Dirk Wagner <dirk.wagner(a)ipfire.org>
> Datum: 11. Mai 2017 um 12:16
> Betreff: 
> 
> One issue remains:
> The constant holdoff_rate_limited_minutes should be overwritable for each provider. For DomainOffensive 30 min ist too short.
> 
> From 312ca7b32852c8b950868423d1919bc2f25031aa Mon Sep 17 00:00:00 2001
> From: Dirk Wagner <dirk.wagner(a)ipfire.org>
> Date: Thu, 11 May 2017 09:04:49 +0200
> Subject: [PATCH] ddns: fixed compile errors
> 
> Signed-off-by: Dirk Wagner <dirk.wagner(a)ipfire.org>
> ---
>  src/ddns/providers.py | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index cb6dd2d..5386f35 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -69,7 +69,7 @@ class DDNSProvider(object):
>  
>  	# holdoff time for rate-limited updates - Number of minutes no update
>  	# is tried after the last one has been sent.
> -	holdoff_rate-limited_minutes = 30
> +	holdoff_rate_limited_minutes = 30
>  
>  	# True if the provider is able to remove records, too.
>  	# Required to remove AAAA records if IPv6 is absent again.
> @@ -248,10 +248,10 @@ class DDNSProvider(object):
>  		last_update = self.db.last_update(self.hostname, status=last_status)
>  
>  		# Calculate holdoff end, based on the last status (failure or rate-limited)
> -		if last_status == "failure"
> +		if last_status == "failure":
>  			holdoff_end = last_update + datetime.timedelta(days=self.holdoff_failure_days)
>  		else:
> -			holdoff_end = last_update + datetime.timedelta(minutes=self.holdoff_rate-limited_minutes)
> +			holdoff_end = last_update + datetime.timedelta(minutes=self.holdoff_rate_limited_minutes)
>  
>  		now = datetime.datetime.utcnow()
>  		if now < holdoff_end:
> -- 
> 2.1.4
>

       reply	other threads:[~2017-05-11 10:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1494497813-2694-1-git-send-email-dirk.wagner@ipfire.org>
2017-05-11 10:23 ` dirk.wagner [this message]
2017-05-24 14:43   ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=99179154.3066.1494498203022@office.mailbox.org \
    --to=dirk.wagner@ipfire.org \
    --cc=ddns@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox