From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: ddns@lists.ipfire.org Subject: Re: [PATCH] Fixes freedns.afraid.org ddns provider Date: Mon, 25 Jan 2021 19:18:23 +0000 Message-ID: <9BE2218D-1A3A-4DE9-9942-A18D35F8E3FA@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6571856115842969255==" List-Id: --===============6571856115842969255== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello, You might be right. This one is the correct one: https://patchwork.ipfire.org/patch/3816/ @Stefan: Can you merge this and tag a release? Best, -Michael > On 25 Jan 2021, at 18:49, Kashif Iftikhar wrote: >=20 > Hi, >=20 > I think you're looking at the older email. The updated patch I posted > does not have the data argument. Pasting it here again just for > reference >=20 > ------------------------BEGIN PATCH--------------------------- >> From ca4865f02594666fc7e1a4578db3465555aae860 Mon Sep 17 00:00:00 2001 > From: Kashif Iftikhar > Date: Fri, 22 Jan 2021 18:24:03 +0500 > Subject: [PATCH 1/1] fixes freedns.afraid.org provider. >=20 > The URL for syncing had changed and now does not require sending the ip > with the request. >=20 > Signed-off-by: Kashif Iftikhar > --- > src/ddns/providers.py | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) >=20 > diff --git a/src/ddns/providers.py b/src/ddns/providers.py > index 56e6620..98d2747 100644 > --- a/src/ddns/providers.py > +++ b/src/ddns/providers.py > @@ -1186,26 +1186,22 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >=20 > # No information about the request or response could be found on the ve= ndor > # page. All used values have been collected by testing. > - url =3D "https://freedns.afraid.org/dynamic/update.php" > + url =3D "https://sync.afraid.org/u/" > can_remove_records =3D False > supports_token_auth =3D True >=20 > def update_protocol(self, proto): > - data =3D { > - "address" : self.get_address(proto), > - } > - > # Add auth token to the update url. > - url =3D "%s?%s" % (self.url, self.token) > + url =3D "%s%s/" % (self.url, self.token) >=20 > # Send update to the server. > - response =3D self.send_request(url, data=3Ddata) > + response =3D self.send_request(url) >=20 > # Get the full response message. > output =3D response.read().decode() >=20 > # Handle success messages. > - if output.startswith("Updated") or "has not changed" in output: > + if output.startswith("Updated") or output.startswith("No IP > change detected"): > return >=20 > # Handle error codes. > --=20 > 2.25.1 >=20 >=20 > ------------------------END PATCH--------------------------- >=20 > Regards. >=20 > On Mon, Jan 25, 2021 at 11:17 PM Michael Tremer > wrote: >>=20 >> Hi, >>=20 >> Thank you for updating the patch, but I think this is now what you wanted. >>=20 >> The data=3D argument is back again and so we will send some data to the se= rver which the server won=E2=80=99t know what to do with. >>=20 >> You probably wanted to remove this, didn=E2=80=99t you? >>=20 >> -Michael >>=20 >>> On 22 Jan 2021, at 13:27, Kashif Iftikhar wro= te: >>>=20 >>> Hello Michael, >>>=20 >>> Thank you for the feedback, I've sent updated (corrected) patch to ddns l= ist. >>>=20 >>> On Fri, Jan 22, 2021 at 6:03 PM Michael Tremer >>> wrote: >>>>=20 >>>> Hello Kashif, >>>>=20 >>>> Thank you for your email. >>>>=20 >>>> If the data argument is no longer required, you should remove it entirel= y instead of just commenting it out. >>>>=20 >>>> Otherwise this looks good. >>>>=20 >>>> Best, >>>> -Michael >>>>=20 >>>>> On 22 Jan 2021, at 12:59, Kashif Iftikhar w= rote: >>>>>=20 >>>>> ------------------------BEGIN PATCH--------------------------- >>>>> From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001 >>>>> From: Kashif Iftikhar >>>>> Date: Fri, 22 Jan 2021 17:33:01 +0500 >>>>> Subject: [PATCH 1/1] fixes freedns.afraid.org provider. >>>>>=20 >>>>> The URL for syncing had changed and now does not require sending the ip >>>>> with the request. >>>>>=20 >>>>> Signed-off-by: Kashif Iftikhar >>>>> --- >>>>> src/ddns/providers.py | 14 +++++++------- >>>>> 1 file changed, 7 insertions(+), 7 deletions(-) >>>>>=20 >>>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >>>>> index 56e6620..6feef33 100644 >>>>> --- a/src/ddns/providers.py >>>>> +++ b/src/ddns/providers.py >>>>> @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider= ): >>>>>=20 >>>>> # No information about the request or response could be found on the = vendor >>>>> # page. All used values have been collected by testing. >>>>> - url =3D "https://freedns.afraid.org/dynamic/update.php" >>>>> + url =3D "https://sync.afraid.org/u/" >>>>> can_remove_records =3D False >>>>> supports_token_auth =3D True >>>>>=20 >>>>> def update_protocol(self, proto): >>>>> - data =3D { >>>>> - "address" : self.get_address(proto), >>>>> - } >>>>> + # data =3D { >>>>> + # "address" : self.get_address(proto), >>>>> + # } >>>>>=20 >>>>> # Add auth token to the update url. >>>>> - url =3D "%s?%s" % (self.url, self.token) >>>>> + url =3D "%s%s/" % (self.url, self.token) >>>>>=20 >>>>> # Send update to the server. >>>>> - response =3D self.send_request(url, data=3Ddata) >>>>> + response =3D self.send_request(url) >>>>>=20 >>>>> # Get the full response message. >>>>> output =3D response.read().decode() >>>>>=20 >>>>> # Handle success messages. >>>>> - if output.startswith("Updated") or "has not changed" in output: >>>>> + if output.startswith("Updated") or output.startswith("No IP >>>>> change detected"): >>>>> return >>>>>=20 >>>>> # Handle error codes. >>>>> -- >>>>> 2.25.1 >>>>>=20 >>>>>=20 >>>>> ------------------------END PATCH--------------------------- >>>>>=20 >>>>> Regards. >>>>> Kashif Iftikhar >>>>> http://kashif.compulife.com.pk >>>>> _______________________________________________ >>>>> ddns mailing list >>>>> ddns(a)lists.ipfire.org >>>>> https://lists.ipfire.org/mailman/listinfo/ddns >>>>=20 >>>=20 >>>=20 >>> -- >>> Kashif Iftikhar >>> http://kashif.compulife.com.pk >>=20 >=20 >=20 > --=20 > Kashif Iftikhar > http://kashif.compulife.com.pk --===============6571856115842969255==--