From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject: Re: [PATCH] ProviderDDNSS: Fix unhandled exception on update
Date: Tue, 26 May 2020 11:11:28 +0100
Message-ID: <AE64972B-159A-45EF-9DDE-DDA7385786DD@ipfire.org>
In-Reply-To: <20200525160545.3816-1-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8688735821860700325=="
List-Id: <ddns.lists.ipfire.org>

--===============8688735821860700325==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

Did you send this to any of the people affected by the problem to test it?

-Michael

> On 25 May 2020, at 17:05, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> In python > 3.3 the getheader() attribute is not longer part of the
> urllib.response response.info() object. It is part of response object
> and so directly can be accessed.
>=20
> Fixes #12328
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> src/ddns/providers.py | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>=20
> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
> index f1fed22..46d8a67 100644
> --- a/src/ddns/providers.py
> +++ b/src/ddns/providers.py
> @@ -642,10 +642,8 @@ class DDNSProviderDDNSS(DDNSProvider):
> 		response =3D self.send_request(self.url, data=3Ddata)
>=20
> 		# This provider sends the response code as part of the header.
> -		header =3D response.info()
> -
> 		# Get status information from the header.
> -		output =3D header.getheader('ddnss-response')
> +		output =3D response.getheader('ddnss-response')
>=20
> 		# Handle success messages.
> 		if output =3D=3D "good" or output =3D=3D "nochg":
> --=20
> 2.26.1
>=20


--===============8688735821860700325==--