From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kashif Iftikhar To: ddns@lists.ipfire.org Subject: Re: [PATCH] Fixes freedns.afraid.org ddns provider Date: Mon, 25 Jan 2021 23:49:55 +0500 Message-ID: In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0776866500457969308==" List-Id: --===============0776866500457969308== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, I think you're looking at the older email. The updated patch I posted does not have the data argument. Pasting it here again just for reference ------------------------BEGIN PATCH--------------------------- >>From ca4865f02594666fc7e1a4578db3465555aae860 Mon Sep 17 00:00:00 2001 From: Kashif Iftikhar Date: Fri, 22 Jan 2021 18:24:03 +0500 Subject: [PATCH 1/1] fixes freedns.afraid.org provider. The URL for syncing had changed and now does not require sending the ip with the request. Signed-off-by: Kashif Iftikhar --- src/ddns/providers.py | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/ddns/providers.py b/src/ddns/providers.py index 56e6620..98d2747 100644 --- a/src/ddns/providers.py +++ b/src/ddns/providers.py @@ -1186,26 +1186,22 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): # No information about the request or response could be found on the ven= dor # page. All used values have been collected by testing. - url =3D "https://freedns.afraid.org/dynamic/update.php" + url =3D "https://sync.afraid.org/u/" can_remove_records =3D False supports_token_auth =3D True def update_protocol(self, proto): - data =3D { - "address" : self.get_address(proto), - } - # Add auth token to the update url. - url =3D "%s?%s" % (self.url, self.token) + url =3D "%s%s/" % (self.url, self.token) # Send update to the server. - response =3D self.send_request(url, data=3Ddata) + response =3D self.send_request(url) # Get the full response message. output =3D response.read().decode() # Handle success messages. - if output.startswith("Updated") or "has not changed" in output: + if output.startswith("Updated") or output.startswith("No IP change detected"): return # Handle error codes. --=20 2.25.1 ------------------------END PATCH--------------------------- Regards. On Mon, Jan 25, 2021 at 11:17 PM Michael Tremer wrote: > > Hi, > > Thank you for updating the patch, but I think this is now what you wanted. > > The data=3D argument is back again and so we will send some data to the ser= ver which the server won=E2=80=99t know what to do with. > > You probably wanted to remove this, didn=E2=80=99t you? > > -Michael > > > On 22 Jan 2021, at 13:27, Kashif Iftikhar wro= te: > > > > Hello Michael, > > > > Thank you for the feedback, I've sent updated (corrected) patch to ddns l= ist. > > > > On Fri, Jan 22, 2021 at 6:03 PM Michael Tremer > > wrote: > >> > >> Hello Kashif, > >> > >> Thank you for your email. > >> > >> If the data argument is no longer required, you should remove it entirel= y instead of just commenting it out. > >> > >> Otherwise this looks good. > >> > >> Best, > >> -Michael > >> > >>> On 22 Jan 2021, at 12:59, Kashif Iftikhar w= rote: > >>> > >>> ------------------------BEGIN PATCH--------------------------- > >>> From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001 > >>> From: Kashif Iftikhar > >>> Date: Fri, 22 Jan 2021 17:33:01 +0500 > >>> Subject: [PATCH 1/1] fixes freedns.afraid.org provider. > >>> > >>> The URL for syncing had changed and now does not require sending the ip > >>> with the request. > >>> > >>> Signed-off-by: Kashif Iftikhar > >>> --- > >>> src/ddns/providers.py | 14 +++++++------- > >>> 1 file changed, 7 insertions(+), 7 deletions(-) > >>> > >>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py > >>> index 56e6620..6feef33 100644 > >>> --- a/src/ddns/providers.py > >>> +++ b/src/ddns/providers.py > >>> @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider= ): > >>> > >>> # No information about the request or response could be found on the= vendor > >>> # page. All used values have been collected by testing. > >>> - url =3D "https://freedns.afraid.org/dynamic/update.php" > >>> + url =3D "https://sync.afraid.org/u/" > >>> can_remove_records =3D False > >>> supports_token_auth =3D True > >>> > >>> def update_protocol(self, proto): > >>> - data =3D { > >>> - "address" : self.get_address(proto), > >>> - } > >>> + # data =3D { > >>> + # "address" : self.get_address(proto), > >>> + # } > >>> > >>> # Add auth token to the update url. > >>> - url =3D "%s?%s" % (self.url, self.token) > >>> + url =3D "%s%s/" % (self.url, self.token) > >>> > >>> # Send update to the server. > >>> - response =3D self.send_request(url, data=3Ddata) > >>> + response =3D self.send_request(url) > >>> > >>> # Get the full response message. > >>> output =3D response.read().decode() > >>> > >>> # Handle success messages. > >>> - if output.startswith("Updated") or "has not changed" in output: > >>> + if output.startswith("Updated") or output.startswith("No IP > >>> change detected"): > >>> return > >>> > >>> # Handle error codes. > >>> -- > >>> 2.25.1 > >>> > >>> > >>> ------------------------END PATCH--------------------------- > >>> > >>> Regards. > >>> Kashif Iftikhar > >>> http://kashif.compulife.com.pk > >>> _______________________________________________ > >>> ddns mailing list > >>> ddns(a)lists.ipfire.org > >>> https://lists.ipfire.org/mailman/listinfo/ddns > >> > > > > > > -- > > Kashif Iftikhar > > http://kashif.compulife.com.pk > --=20 Kashif Iftikhar http://kashif.compulife.com.pk --===============0776866500457969308==--