From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: ddns@lists.ipfire.org
Subject: Re: [PATCH] Fixes freedns.afraid.org ddns provider
Date: Mon, 25 Jan 2021 18:17:06 +0000
Message-ID: <D62DBB83-ACC5-4AF1-B7DC-F133E496A240@ipfire.org>
In-Reply-To:
 <CAHoP+V8qk=kZoB2MJ1nv1yKiz4oxfuDRFKx4Nvs=QGza07K7SQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1647457961859751416=="
List-Id: <ddns.lists.ipfire.org>

--===============1647457961859751416==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

Thank you for updating the patch, but I think this is now what you wanted.

The data=3D argument is back again and so we will send some data to the serve=
r which the server won=E2=80=99t know what to do with.

You probably wanted to remove this, didn=E2=80=99t you?

-Michael

> On 22 Jan 2021, at 13:27, Kashif Iftikhar <kashif(a)compulife.com.pk> wrote:
>=20
> Hello Michael,
>=20
> Thank you for the feedback, I've sent updated (corrected) patch to ddns lis=
t.
>=20
> On Fri, Jan 22, 2021 at 6:03 PM Michael Tremer
> <michael.tremer(a)ipfire.org> wrote:
>>=20
>> Hello Kashif,
>>=20
>> Thank you for your email.
>>=20
>> If the data argument is no longer required, you should remove it entirely =
instead of just commenting it out.
>>=20
>> Otherwise this looks good.
>>=20
>> Best,
>> -Michael
>>=20
>>> On 22 Jan 2021, at 12:59, Kashif Iftikhar <kashif(a)compulife.com.pk> wro=
te:
>>>=20
>>> ------------------------BEGIN PATCH---------------------------
>>> From ed8e4a9e53cbd24e4a0450e3a8aa1c12359cbe2e Mon Sep 17 00:00:00 2001
>>> From: Kashif Iftikhar <kashif(a)compulife.com.pk>
>>> Date: Fri, 22 Jan 2021 17:33:01 +0500
>>> Subject: [PATCH 1/1] fixes freedns.afraid.org provider.
>>>=20
>>> The URL for syncing had changed and now does not require sending the ip
>>> with the request.
>>>=20
>>> Signed-off-by: Kashif Iftikhar <kashif(a)compulife.com.pk>
>>> ---
>>> src/ddns/providers.py | 14 +++++++-------
>>> 1 file changed, 7 insertions(+), 7 deletions(-)
>>>=20
>>> diff --git a/src/ddns/providers.py b/src/ddns/providers.py
>>> index 56e6620..6feef33 100644
>>> --- a/src/ddns/providers.py
>>> +++ b/src/ddns/providers.py
>>> @@ -1186,26 +1186,26 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider):
>>>=20
>>>    # No information about the request or response could be found on the v=
endor
>>>    # page. All used values have been collected by testing.
>>> -    url =3D "https://freedns.afraid.org/dynamic/update.php"
>>> +    url =3D "https://sync.afraid.org/u/"
>>>    can_remove_records =3D False
>>>    supports_token_auth =3D True
>>>=20
>>>    def update_protocol(self, proto):
>>> -        data =3D {
>>> -            "address" : self.get_address(proto),
>>> -        }
>>> +        # data =3D {
>>> +        #     "address" : self.get_address(proto),
>>> +        # }
>>>=20
>>>        # Add auth token to the update url.
>>> -        url =3D "%s?%s" % (self.url, self.token)
>>> +        url =3D "%s%s/" % (self.url, self.token)
>>>=20
>>>        # Send update to the server.
>>> -        response =3D self.send_request(url, data=3Ddata)
>>> +        response =3D self.send_request(url)
>>>=20
>>>        # Get the full response message.
>>>        output =3D response.read().decode()
>>>=20
>>>        # Handle success messages.
>>> -        if output.startswith("Updated") or "has not changed" in output:
>>> +        if output.startswith("Updated") or output.startswith("No IP
>>> change detected"):
>>>            return
>>>=20
>>>        # Handle error codes.
>>> --
>>> 2.25.1
>>>=20
>>>=20
>>> ------------------------END PATCH---------------------------
>>>=20
>>> Regards.
>>> Kashif Iftikhar
>>> http://kashif.compulife.com.pk
>>> _______________________________________________
>>> ddns mailing list
>>> ddns(a)lists.ipfire.org
>>> https://lists.ipfire.org/mailman/listinfo/ddns
>>=20
>=20
>=20
> --=20
> Kashif Iftikhar
> http://kashif.compulife.com.pk


--===============1647457961859751416==--