From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Koch To: ddns@lists.ipfire.org Subject: Re: [PATCH] Add new provider INWX (https://www.inwx.com) Date: Fri, 20 Sep 2019 13:20:08 +0200 Message-ID: In-Reply-To: <2498526A-6EDA-464B-B03C-9D9E63252619@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============8748372789453681931==" List-Id: --===============8748372789453681931== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, -------- Original Message -------- From: Michael Tremer [mailto:michael.tremer(a)ipfire.org] Sent: Thursday, 19 September 2019, 14:57 CEST To: Alexander Koch Cc: ddns(a)lists.ipfire.org Subject: [PATCH] Add new provider INWX (https://www.inwx.com) > Hi, >=20 > Thank you for sending this patch, but I am afraid I have a little bit of a = problem here=E2=80=A6 >=20 >> On 18 Sep 2019, at 15:25, Alexander Koch = wrote: >> >> This includes: >> >> - inwx.com >> - inwx.de >> - inwx.at >> - inwx.ch >> - inwx.es >> >> Signed-off-by: Alexander Koch >> --- >> README | 1 + >> configure.ac | 2 +- >> src/ddns/providers.py | 15 ++++++++++++++- >> 3 files changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/README b/README >> index b0601a0..0f2798e 100644 >> --- a/README >> +++ b/README >> @@ -68,6 +68,7 @@ SUPPORTED PROVIDERS: >> enom.com >> entrydns.net >> freedns.afraid.org >> + inwx.com|de|at|ch|es >> itsdns.de >> joker.com >> loopia.se >> diff --git a/configure.ac b/configure.ac >> index 008950d..14bccc0 100644 >> --- a/configure.ac >> +++ b/configure.ac >> @@ -21,7 +21,7 @@ >> AC_PREREQ([2.64]) >> >> AC_INIT([ddns], >> - [011], >> + [012], >> [info(a)ipfire.org], >> [ddns], >> [http://git.ipfire.org/?p=3Doddments/ddns.git;a=3Dsummary]) >=20 > You don=E2=80=99t need to increment the version number. That will be done b= y the maintainer when ever it is decided to have a new release. >=20 Ok. >> diff --git a/src/ddns/providers.py b/src/ddns/providers.py >> index 4ffd8bf..12116e3 100644 >> --- a/src/ddns/providers.py >> +++ b/src/ddns/providers.py >> @@ -1003,7 +1003,7 @@ class DDNSProviderDynsNet(DDNSProvider): >> raise DDNSInternalServerError >> >> # If we got here, some other update error happened. >> - raise DDNSUpdateError(_("Server response: %s") % output) >> + raise DDNSUpdateError(_("Server response: %s") % output) >> >=20 > Whitespace changes like this should not be included in this patch. This cou= ld be an extra patch. >=20 Ok. My text editor corrected this automatically. I didn't think about it any = further... >> class DDNSProviderEnomCom(DDNSResponseParserXML, DDNSProvider): >> @@ -1129,6 +1129,19 @@ class DDNSProviderFreeDNSAfraidOrg(DDNSProvider): >> raise DDNSUpdateError >> >> >> +class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >> + handle =3D "inwx.com" >> + name =3D "INWX" >> + website =3D "https://www.inwx.com" >> + protocols =3D ("ipv6", "ipv4") >> + >> + # Information about the format of the HTTP request is to be found >> + # here: https://www.inwx.com/en/nameserver2/dyndns (requires login) >> + # Notice: The URL is the same for: inwx.com|de|at|ch|es >> + >> + url =3D "https://dyndns.inwx.com/nic/update" >> + >> + >=20 > My problem with this provider is that the documentation is not publicly acc= essible. Therefore this is not maintainable for everyone who does not have an= account there. Creating an account with every single ISP is of course not an= option either. >=20 > I would be interested to hear what Stefan and others think about this. >=20 > Best, > -Michael >=20 I get your point. I did some research in their KB - without login - but could= n't find an alternative place providing the infos. They use the dyndns2-proto= col without any modifications. The only information they provide at the given= URL (with login) is the Update-URL: https://dyndns.inwx.com/nic/update?myip= =3D&myipv6=3D I doubt they will ever change this, unless the= y move to another protocol ... this would then be reported as a bug by a user= who has a login and is able to provide further information though. I've got an alternative idea to solve this. As they (and some other of the al= ready implemented providers) are using the dyndns2-protocoll without any modi= fications, why not add a specific handle "DynDNS2 misc" to the service-dropdo= wn (or an additional dropdown for the protocol) and a textfield for the Updat= e-URL on the Web UI and create a unified handle for all dyndns2-providers in = providers.py. The Update-URL for the dydns2-service can easily be provided by= the user. This would simplify the maintenance of ddns on one side and provid= e support for more dyndns2-services without any effort on the other side. A s= imilar approach could be used for other existent/future standardized dyndns-s= ervice-protocolls. Please let me know what you think about it. I offer to work on a patch for th= e "DynDNS2 misc"-service if you like the idea. >> class DDNSProviderItsdns(DDNSProtocolDynDNS2, DDNSProvider): >> handle =3D "itsdns.de" >> name =3D "it's DNS" >> --=20 >> 2.17.1 >> >> _______________________________________________ >> ddns mailing list >> ddns(a)lists.ipfire.org >> https://lists.ipfire.org/mailman/listinfo/ddns >=20 Regards, Alex --===============8748372789453681931==--