From: Wolfgang Apolinarski <wolfgang.apolinarski@googlemail.com>
To: development@lists.ipfire.org
Subject: Bug #11494
Date: Tue, 03 Oct 2017 13:19:30 +0200 [thread overview]
Message-ID: <000001d33c39$7c8b6930$75a23b90$@googlemail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1128 bytes --]
Hi,
thanks for discovering the bug, I'm sorry that I did not find it during my tests. Regarding a possible solution, I have the following comment:
We could resolve it in 3 different files:
extrahd.pl - which actually emits the output by a PRINT statement (line 51) which looks a little bit like a debug statement. Nevertheless, it might make sense that this file gives some output.
extrahdctrl.c - which only calls the extrahd.pl, but might be used by users in the commandline, so removing/redirecting the stdout could make sense, but still it might be that users actually expect output here. Alternatively, a --quiet option could be introduced here that suppresses the output.
extrahd.cgi - which is used by the web-frontend. Here, the "system" call could be exchanged with an "qx" call or backticks, which would maybe make it more explicit that we are not using stdout at this point. The commands could then be unchanged. I'm not a perl expert, so I'm not familiar if qx is preferred over system when the stdout should be ignored. In php, exec would be more appropriate, I suppose.
Best regards,
Wolfgang
next reply other threads:[~2017-10-03 11:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-03 11:19 Wolfgang Apolinarski [this message]
2017-10-03 12:44 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d33c39$7c8b6930$75a23b90$@googlemail.com' \
--to=wolfgang.apolinarski@googlemail.com \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox