From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Apolinarski To: development@lists.ipfire.org Subject: Bug #11494 Date: Tue, 03 Oct 2017 13:19:30 +0200 Message-ID: <000001d33c39$7c8b6930$75a23b90$@googlemail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6654079766099768070==" List-Id: --===============6654079766099768070== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi, thanks for discovering the bug, I'm sorry that I did not find it during my te= sts. Regarding a possible solution, I have the following comment: We could resolve it in 3 different files: extrahd.pl - which actually emits the output by a PRINT statement (line 51) w= hich looks a little bit like a debug statement. Nevertheless, it might make s= ense that this file gives some output. extrahdctrl.c - which only calls the extrahd.pl, but might be used by users = in the commandline, so removing/redirecting the stdout could make sense, but = still it might be that users actually expect output here. Alternatively, a --= quiet option could be introduced here that suppresses the output. extrahd.cgi - which is used by the web-frontend. Here, the "system" call coul= d be exchanged with an "qx" call or backticks, which would maybe make it more= explicit that we are not using stdout at this point. The commands could then= be unchanged. I'm not a perl expert, so I'm not familiar if qx is preferred = over system when the stdout should be ignored. In php, exec would be more app= ropriate, I suppose. Best regards, Wolfgang --===============6654079766099768070==--