public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Wolfgang Apolinarski <wolfgang@apolinarski.de>
To: development@lists.ipfire.org
Subject: AW: Upgrade to Apache 2.4
Date: Sun, 16 Apr 2017 23:13:52 +0200	[thread overview]
Message-ID: <001f01d2b6f6$5a119f00$0e34dd00$@apolinarski.de> (raw)
In-Reply-To: <1492359167.2083.2.camel@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 2427 bytes --]

Hi Michael,

I read the page before posting to the list, but
a) I wanted to make sure that you are at all interested in an upgrade to apache 2.4
b) It says "You may also use git send-email or send a Git pull request which is the recommended way for patch sets."
(and I thought that git pull request is what Github (in this case) is for)

I broke down the patch into 4 smaller patches, but I wanted to make sure that each patch can be applied individually such that IPFire is not only building, but apache also does not crash on startup.

Therefore, the apache-update patch is still not that small, but the configuration changes are necessary because of the changed syntax.

I will now configure and use git send-email for the patches.

Best regards,
Wolfgang
PS.: I still have to build and test the individual patches, since I only tested the complete patch-set.

-----Ursprüngliche Nachricht-----
Von: Michael Tremer [mailto:michael.tremer(a)ipfire.org] 
Gesendet: Sonntag, 16. April 2017 18:13
An: Wolfgang Apolinarski <wolfgang(a)apolinarski.de>; development(a)lists.ipfire.org
Betreff: Re: Upgrade to Apache 2.4

Hello,

could you please post this as explained here:

  http://wiki.ipfire.org/devel/submit-patches

This will allow us to comment on the changes. I do have quite a number of questions and remarks.

This is also a very huge patch, so I would prefer it if it was broken into smaller individual patches. It is all explained on the wiki.

Best,
-Michael

On Fri, 2017-04-14 at 16:25 +0200, Wolfgang Apolinarski wrote:
> Hi everyone,
> 
> I created an upgrade to Apache 2.4:
> https://github.com/wapolinar/ipfire-2.x/tree/apache_24
> 
> It should be up-to-date with the current next branch, but I could 
> rebase/merge it with whatever branch you want me to.
> I also had to update some configuration files of addons, because they 
> did not comply to the Apache 2.4 syntax. Please have a look at this 
> changes as well, I tested them on my virtual IPFire machine and as far 
> as I could see it they are working, but there might be some problems.
> 
> I'm willing to change the apache configuration of other 
> addons/configuration files, if necessary.
> 
> If you think that IPFire does not need this update, this is also ok to 
> me, I started creating it, after the discussion about the 
> htpasswd-tool started.
> 
> Best regards,
> Wolfgang
> 


  reply	other threads:[~2017-04-16 21:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-14 14:25 Wolfgang Apolinarski
2017-04-16 16:12 ` Michael Tremer
2017-04-16 21:13   ` Wolfgang Apolinarski [this message]
2017-04-18 12:05     ` AW: " Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001f01d2b6f6$5a119f00$0e34dd00$@apolinarski.de' \
    --to=wolfgang@apolinarski.de \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox