Hi Michael,

I read the page before posting to the list, but
a) I wanted to make sure that you are at all interested in an upgrade to apache 2.4
b) It says "You may also use git send-email or send a Git pull request which is the recommended way for patch sets."
(and I thought that git pull request is what Github (in this case) is for)

I broke down the patch into 4 smaller patches, but I wanted to make sure that each patch can be applied individually such that IPFire is not only building, but apache also does not crash on startup.

Therefore, the apache-update patch is still not that small, but the configuration changes are necessary because of the changed syntax.

I will now configure and use git send-email for the patches.

Best regards,
Wolfgang
PS.: I still have to build and test the individual patches, since I only tested the complete patch-set.

-----Ursprüngliche Nachricht-----
Von: Michael Tremer [mailto:michael.tremer(a)ipfire.org] 
Gesendet: Sonntag, 16. April 2017 18:13
An: Wolfgang Apolinarski <wolfgang(a)apolinarski.de>; development(a)lists.ipfire.org
Betreff: Re: Upgrade to Apache 2.4

Hello,

could you please post this as explained here:

  http://wiki.ipfire.org/devel/submit-patches

This will allow us to comment on the changes. I do have quite a number of questions and remarks.

This is also a very huge patch, so I would prefer it if it was broken into smaller individual patches. It is all explained on the wiki.

Best,
-Michael

On Fri, 2017-04-14 at 16:25 +0200, Wolfgang Apolinarski wrote:
> Hi everyone,
> 
> I created an upgrade to Apache 2.4:
> https://github.com/wapolinar/ipfire-2.x/tree/apache_24
> 
> It should be up-to-date with the current next branch, but I could 
> rebase/merge it with whatever branch you want me to.
> I also had to update some configuration files of addons, because they 
> did not comply to the Apache 2.4 syntax. Please have a look at this 
> changes as well, I tested them on my virtual IPFire machine and as far 
> as I could see it they are working, but there might be some problems.
> 
> I'm willing to change the apache configuration of other 
> addons/configuration files, if necessary.
> 
> If you think that IPFire does not need this update, this is also ok to 
> me, I started creating it, after the discussion about the 
> htpasswd-tool started.
> 
> Best regards,
> Wolfgang
>