public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] backupiso: Update to ISO file naming - bug#12932
Date: Sun, 18 Sep 2022 22:42:38 +0200	[thread overview]
Message-ID: <0033c546-d0c1-acee-6fa1-8bb7afe77181@ipfire.org> (raw)
In-Reply-To: <20220918114517.7508-1-adolf.belka@ipfire.org>

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>

Am 18.09.2022 um 13:45 schrieb Adolf Belka:
> - commit https://git.ipfire.org/?p=ipfire-2.x.git;a=commit;h=fbd0608c2cb5372fff7857065ec7e605b1bf9cf7
>     aligned the ISO file name to the image file name. This change also needed to be added
>     to backupiso as the filename is used to download the iso from the IPFire server when
>     creating an ISO backup.
> 
> Fixes: Bug#12932
> Suggested-by: Matthias Fischer <matthias.fischer(a)ipfire.org>
> Tested-by: Adolf Belka <adolf.belka(a)ipfire.org>
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
>   src/scripts/backupiso | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/scripts/backupiso b/src/scripts/backupiso
> index ef017e3be..2a016e067 100644
> --- a/src/scripts/backupiso
> +++ b/src/scripts/backupiso
> @@ -35,7 +35,7 @@ case "${arch}" in
>   esac
>   
>   URL="https://downloads.ipfire.org/releases/ipfire-2.x/$IPFVER-core$COREVER/"
> -ISO="ipfire-$IPFVER.$arch-full-core$COREVER.iso"
> +ISO="ipfire-$IPFVER-core$COREVER-$arch.iso"
>   
>   makeiso() {
>   	local dir="${1}"

      reply	other threads:[~2022-09-18 20:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-18 11:45 Adolf Belka
2022-09-18 20:42 ` Bernhard Bitsch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0033c546-d0c1-acee-6fa1-8bb7afe77181@ipfire.org \
    --to=bbitsch@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox