From mboxrd@z Thu Jan  1 00:00:00 1970
From: Bernhard Bitsch <bbitsch@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCHv2 11/12] extrahd.cgi: Do not allow "/mnt" or "/media" as
 mount points
Date: Wed, 02 Aug 2023 14:11:28 +0200
Message-ID: <00da3025-ed1b-7248-037f-43e19535e423@ipfire.org>
In-Reply-To: <20230801154839.2373-11-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8905949555960586795=="
List-Id: <development.lists.ipfire.org>

--===============8905949555960586795==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>


Am 01.08.2023 um 17:48 schrieb Stefan Schantl:
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
>   html/cgi-bin/extrahd.cgi | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/html/cgi-bin/extrahd.cgi b/html/cgi-bin/extrahd.cgi
> index 122f1d12d..bd64dff07 100644
> --- a/html/cgi-bin/extrahd.cgi
> +++ b/html/cgi-bin/extrahd.cgi
> @@ -667,6 +667,10 @@ sub is_mounted ($) {
>   sub is_valid_dir ($) {
>   	my ($mpoint) = @_;
>   
> +	# Do not allow "/mnt" or "/media" as mount points.
> +	return if($mpoint eq "/mnt");
> +	return if($mpoint eq "/media");
> +
>   	# Split the given mountpoint into pieces and store them
>   	# in a temporay array.
>   	my @tmp = split("/", $mpoint);

--===============8905949555960586795==--