From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cups: for now cups make a backup on uninstall
Date: Sun, 01 May 2022 18:56:33 +0200
Message-ID: <014565b8-149b-9bf9-6a23-528ccbb3790a@ipfire.org>
In-Reply-To: <20220428142416.23557-1-daniel.weismueller@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============4884436773124406559=="
List-Id: <development.lists.ipfire.org>

--===============4884436773124406559==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Reviewed-by: Adolf Belka <adolf.belka(a)ipfire.org>

On 28/04/2022 16:24, Daniel Weismueller wrote:
> and a restore on install / update
>
> The include file that was added in a previous commit allowed to manually
> create a backup, but none was created when the addon was installed,
> uninstalled or updated.
>
> Signed-off-by: Daniel Weismueller <daniel.weismueller(a)ipfire.org>
> ---
>   src/paks/cups/install.sh   | 1 +
>   src/paks/cups/uninstall.sh | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/src/paks/cups/install.sh b/src/paks/cups/install.sh
> index b3f0f1368..cc5866971 100644
> --- a/src/paks/cups/install.sh
> +++ b/src/paks/cups/install.sh
> @@ -23,6 +23,7 @@
>   #
>   . /opt/pakfire/lib/functions.sh
>   extract_files
> +restore_backup "${NAME}"
>   /etc/init.d/messagebus reload
>   start_service --delay 300 --background ${NAME}
>   ln -svf ../init.d/cups /etc/rc.d/rc0.d/K00cups
> diff --git a/src/paks/cups/uninstall.sh b/src/paks/cups/uninstall.sh
> index 01b13de76..d4abdde63 100644
> --- a/src/paks/cups/uninstall.sh
> +++ b/src/paks/cups/uninstall.sh
> @@ -23,6 +23,7 @@
>   #
>   . /opt/pakfire/lib/functions.sh
>   stop_service ${NAME}
> +make_backup "${NAME}"
>   remove_files
>   rm -rf /etc/rc.d/rc*.d/*cups
>   /etc/init.d/messagebus reload

--===============4884436773124406559==--