From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: sslh (and some general AddOn questions) Date: Fri, 15 Jan 2021 13:43:40 +0100 Message-ID: <01c25fd8-7fd8-9d2e-c445-92fcc89bafe0@ipfire.org> In-Reply-To: <20210115113545.GA2763257@vesikko.tarvainen.info> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1943266772012121857==" List-Id: --===============1943266772012121857== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Tapani, On 15/01/2021 12:35, Tapani Tarvainen wrote: > Dear all, > > The version of sslh in IPFire now, 1.7a, is very old, some 10 years, > and its parameters are hardcoded in /etc/init.d/sslh for one specific > use case (IPFire admin access). > > I have a different use case for it: sharing port 443 with OpenVPN and > a web server in Orange. That would be easy with a more recent version > of sslh (OpenVPn first appeared in 1.8 in July 2011). > > So I'd like to update the sslh AddOn with > > (1) A more recent version of sslh. Latest upstream version is 1.21, > released on 11 July 2020, and I see no obvious reason not to use it, > although for the present purpose some older version might do as well. > > Are there some specific procedures for updating AddOn binaries? It is not a binary in the sense I would understand. The source file has c cod= e in it that the required binaries are created from using the Makefile with a= utotools. Are you meaning something different from your comment? > (2) Parameters in a configuration file. I'd be happy to edit it by > hand, writing a GUI for it would probably not be worth the trouble. > > Is there some convention or guidelines where in IPFire such > configuration files should be put? Debian uses /etc/defaults/sslh, > sslh changelog presently suggests /etc/sslh.cfg. The addons generally have any config files either directly under /etc or in a= directory under /etc named after the addon program. > Should a default configuration file be packaged as a separate > file, or should the init script create one if it's missing > or should it just use the hardcoded defaults in that case? I would say that is up to the person updating the addon. sslh has its own add= on page in the wiki but it isn't listed in the main addons page that lists al= l addons. You can only find it with the search bar in the wiki or if you know= the url. https://wiki.ipfire.org/addons/sslh My feeling would be not to have a specific use case hard coded in the init sc= ript but rather have a default config file. The source file includes a basic.= cfg which could be used to fill that role. Then the addon page could be exten= ded to mention about the cfg file and the need to review it before starting s= slh. > Are there guidelines or instructions for doing or proposing such > changes to AddOns? The wiki page on building addons can also be applied to updating or upgrading= them. It helped me when I was first starting with updating the bacula addon.= https://wiki.ipfire.org/devel/ipfire-2-x/addon-howto > I can't even find a category for them in the Bugzilla. Is there one? > > My apologies if I'm missing something obvious, pointers to > documentation would be welcome. > Hope the above inputs help. Regards, Adolf. --===============1943266772012121857==--