From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matthias Fischer <matthias.fischer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: Backup: Rework and altering of functionalities and GUI for better
 usability
Date: Mon, 22 Mar 2021 18:30:57 +0100
Message-ID: <02acf598-7e3a-c4a3-e13f-4bd6e38df357@ipfire.org>
In-Reply-To: <572900B7-43E8-4F0E-8E39-286EB70FD537@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1001869564228409924=="
List-Id: <development.lists.ipfire.org>

--===============1001869564228409924==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hi,

please note: I added my thoughts below.

On 22.03.2021 12:36, Michael Tremer wrote:
> Hello,
>=20
>> On 21 Mar 2021, at 18:25, Matthias Fischer <matthias.fischer(a)ipfire.org>=
 wrote:
>>=20
>> Based on https://bugzilla.ipfire.org/show_bug.cgi?id=3D12588
>>=20
>> Hi,
>>=20
>> in the meantime I worked on this - a bit.
>=20
> Very good idea. This page is quite essential, but the design is quite compl=
icated and difficult to use.
>=20
>> I've made several changes and adjustments which could be implemented one
>> by one - if they are wanted/accepted:
>>=20
>> - Changed icons to buttons =3D> better readability.
>=20
> Yes. I am not sure whether =E2=80=9CBackup=E2=80=9D is a good choice, becau=
se it could be interpreted as a noun. Maybe =E2=80=9CBackup Now=E2=80=9D or =
=E2=80=9CUpdate Backup=E2=80=9D would be a better choice. Does anybody have a=
ny ideas?

"Save config"? Important: when using buttons, the text should not be too
long. Translation strings for normal-backup/restore and
addon-backup/restore *must* differ.

>> - For buttons to work, I added two lang strings for button labeling.
>=20
> No problem here.
>=20
>> - Cleaned up the code a bit, some if-queries were unnessecary (if
>> ($cgiparams{'ACTION'} eq...).
>>=20
>> - Changed the order of the (Addon-)buttons to "Download - Save - Delete"
>> (old: Download was in the middle).
>=20
> What is the rationale here?
>=20
> Why is this order better?

I changed this because nearly every page on my IPFire has the 'delete'
function - mostly icons - on the far *right* side (e.g.: wio, DNS, dhcp,
hosts, wake on lan, etc.) So I thought that placing the 'delete' button
in the *middle* made no sense here. Too often, I clicked the wrong icon
on the backup page. With text buttons and the changed placement that
didn't happen anymore.

>> - Marked IPF-files bold =3D> better readability (I already sent this in
>> one day: =3D> https://patchwork.ipfire.org/patch/3124/).
>=20
> Can we not have a proper table here? Like this:
>=20
> | Package    | Last Backup      | Size |                              |
> | wio        | 2021-03-22 11:31 | 8 kB | [Download] [Backup] [Delete] |

I won't have much time in the future, but I'll "see what I can get". ;-)

>> - Added query for deleting a backup file (onclick=3D\"return confirm...).
>=20
> Very good idea, too.

Not from me - just using it. That's what friends are for... ;-)

> Can we make this a function that we can add to various other places, too? L=
ike firewall rules?

Yep. Working here in the following GUIs: aliases, backup, connscheduler,
ddns, dhcp, firewall, hosts, media, proxy, qos, routing, urlfilter,
wakeonlan, wio and wireless.

Best,
Matthias

>> Details in the attached screenshot.
>>=20
>> Proposed ToDo - as a start: Alter the info text for restoring to make
>> clear that only the addon *configs* are restored, not the addons themselve=
s.
>=20
> Yes.
>=20
>> Thoughts? Opinions?
>=20
> Very good ideas. Please keep them all in individual patches so that they ca=
n be reviewed one by one :)
>=20
> -Michael
>=20
>>=20
>> Best,
>> Matthias
>> <backup-cgi-tuned.png>
>=20


--===============1001869564228409924==--