From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter =?utf-8?q?M=C3=BCller?= To: development@lists.ipfire.org Subject: Re: work in progress: ppp 2.4.9 Date: Thu, 01 Apr 2021 18:34:17 +0200 Message-ID: <0307d85d-c5aa-5f7c-eaa3-7bb2f9ba668a@ipfire.org> In-Reply-To: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7640171856703341491==" List-Id: --===============7640171856703341491== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hello Michael, hello *, yes, and this is certainly a good sign in terms of security. :-) Some of these patches are indeed not necessary anymore, but the majority stil= l is. However, compiling ppp 2.4.9 fails since it does not find its own libraries i= ncluded: > make[2]: Entering directory '/usr/src/ppp-2.4.9/pppd/plugins' > make[2]: warning: -jN forced in submake: disabling jobserver mode. > gcc -o minconn.so -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtune= =3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D2= -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing minc= onn.c > gcc -o passprompt.so -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtun= e=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D= 2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing pas= sprompt.c > gcc -o passwordfd.so -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtun= e=3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D= 2 -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing pas= swordfd.c > gcc -o winbind.so -shared -O2 -pipe -Wall -fexceptions -fPIC -m64 -mtune= =3Dgeneric -fstack-clash-protection -fcf-protection -Wp,-D_FORTIFY_SOURCE=3D2= -Wp,-D_GLIBCXX_ASSERTIONS -fstack-protector-strong -fno-strict-aliasing winb= ind.c > minconn.c:37:10: fatal error: pppd.h: No such file or directory > 37 | #include "pppd.h" > | ^~~~~~~~ > compilation terminated. > make[2]: *** [Makefile:38: minconn.so] Error 1 > make[2]: *** Waiting for unfinished jobs.... > passprompt.c:15:10: fatal error: pppd.h: No such file or directory > 15 | #include "pppd.h" > | ^~~~~~~~ > compilation terminated. > make[2]: *** [Makefile:38: passprompt.so] Error 1 > winbind.c:37:10: fatal error: pppd.h: No such file or directory > 37 | #include "pppd.h" > | ^~~~~~~~ > compilation terminated. > passwordfd.c:15:10: fatal error: pppd.h: No such file or directory > 15 | #include "pppd.h" > | ^~~~~~~~ > compilation terminated. > make[2]: *** [Makefile:38: winbind.so] Error 1 > make[2]: *** [Makefile:38: passwordfd.so] Error 1 > make[2]: Leaving directory '/usr/src/ppp-2.4.9/pppd/plugins' > make[1]: *** [Makefile:14: all] Error 2 > make[1]: Leaving directory '/usr/src/ppp-2.4.9' > make: *** [ppp:83: /usr/src/log/ppp-2.4.9] Error 2 Since I never experienced the need to fix something like this for IPFire, I a= m a bit unsure what the projects' convention says in this case. Passing these directo= ries via the CFLAGS ("-I /usr/src/ppp-2.4.9/") seems ugly to me. What do we do in this case? :-) Thanks, and best regards, Peter M=C3=BCller > Hello, >=20 > It seems that a new maintainer has taken over pppd and started with merging= many upstream patches that various distributions have been carrying around w= ith them for a long time. >=20 > All patches currently in next are security stuff and no functionality. It m= ight not be bad if this patch does not apply exactly if the new maintainer(s)= found a different solution. >=20 > I believe some of the patches are rather hacky. >=20 > Best, > -Michael >=20 >> On 31 Mar 2021, at 18:01, Peter M=C3=BCller w= rote: >> >> Hello development folks, >> >> for your information: I am currently working on ppp 2.4.9, which turns out= to be rather >> tricky as many of our patches won't apply and/or are not necessary anymore. >> >> Thanks, and best regards, >> Peter M=C3=BCller >=20 --===============7640171856703341491==--