public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Adolf Belka <adolf.belka@ipfire.org>
To: development@lists.ipfire.org
Subject: OpenVPN cipher negotiation patch set
Date: Sun, 17 Mar 2024 12:35:06 +0100	[thread overview]
Message-ID: <0341a854-9743-4372-85d5-50de3cc84f2a@ipfire.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]

Hi Michael,

I am afraid I don't have a patch set. It is just a single diff change.

I took Erik's original patch set and applied it to the latest ovpnmain.cgi version at that time and then removed some of the items that I decided could wait till later or were not needed.

This created a single diff file, which I was able to apply and test out to confirm it did what I expected it to do, which it seemed to do.

The next step I then had intended to do was to break that single diff into multiple patches but I found this very difficult to do as I could not easily figure out which bits needed to go together in different patches. Trying to understand all the changes and what each were related to I struggled to make sense of.

My next step was therefore going to be to go back to an unmodified ovpnmain.cgi file and make the changes a step at a time, to match what I had previously done and therefore end up with a patch set of small self consistent changes.

However to do this I had to go back to the start and figure out which of Erik's changes to apply and what parts of those changes and every time I did something else in IPFire for a week or so I was having to go back to square one in trying to remember what I had been going to do next.

The diff patch file I created is at

https://git.ipfire.org/?p=people/bonnietwin/ipfire-2.x.git;a=commit;h=4fbf17f4a10fbf2a0ddeae1aa436cf26f6b3a035

Hopefully you can use this as a basis to extract just the bits needed for the cipher negotiation.

I will also go back and start again to work on it but focus on it without diverting to anything else, after I have dealt with the wsdd patch modification.

Regards,

Adolf.


             reply	other threads:[~2024-03-17 11:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-17 11:35 Adolf Belka [this message]
2024-03-18  7:49 ` ummeegge
2024-03-18 11:27   ` Adolf Belka
2024-03-18 16:47     ` Michael Tremer
2024-03-18 16:33 ` Michael Tremer
2024-03-21 13:19 ` ummeegge
     [not found] <fadc217d-3072-4bf6-9147-527a5ccb9dd4@howitts.co.uk>
2024-03-17 14:05 ` Adolf Belka
2024-03-18 16:39 ` Michael Tremer
     [not found] <bd1306e2-b063-4dcd-a203-a987a5349c07@howitts.co.uk>
2024-03-18 16:43 ` Michael Tremer
     [not found] <acf8e2b6-b030-4bba-a64a-f740a45cde50@howitts.co.uk>
2024-03-18 16:45 ` Michael Tremer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0341a854-9743-4372-85d5-50de3cc84f2a@ipfire.org \
    --to=adolf.belka@ipfire.org \
    --cc=development@lists.ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox