From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] system.cgi: correctly translate CPU frequency
Date: Sat, 11 Apr 2020 10:32:04 +0100 [thread overview]
Message-ID: <035028D8-1642-40B6-A128-1744FC5E6E85@ipfire.org> (raw)
In-Reply-To: <f200ab55-1680-bc38-fc15-74c9b894e22d@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 2255 bytes --]
Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
> On 11 Apr 2020, at 10:02, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>
> The CPU frequency diagram used the same "translation" as the CPU load,
> which was confusing. This patch introduces a dedicated translation for
> "CPU frequency", which makes things a little bit better but still does
> not solve a Deppenleerzeichen ("CPU-Frequenz Diagramm") in the German
> translation.
>
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/system.cgi | 2 +-
> langs/de/cgi-bin/de.pl | 1 +
> langs/en/cgi-bin/en.pl | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
> index 487ba996c..d7db9406a 100644
> --- a/html/cgi-bin/system.cgi
> +++ b/html/cgi-bin/system.cgi
> @@ -61,7 +61,7 @@ if ( $querry[0] =~ "cpufreq"){
> &Header::closebox();
>
> if ( -e "$mainsettings{'RRDLOG'}/collectd/localhost/cpufreq/cpufreq-0.rrd"){
> - &Header::openbox('100%', 'center', "CPU $Lang::tr{'graph'}");
> + &Header::openbox('100%', 'center', "$Lang::tr{'cpu frequency'} $Lang::tr{'graph'}");
> &Graphs::makegraphbox("system.cgi","cpufreq","day");
> &Header::closebox();
> }
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index c3702cc09..9f1768e78 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -662,6 +662,7 @@
> 'country' => 'Land',
> 'country codes and flags' => 'Länder und Länderkennungen',
> 'countrycode' => 'Kennung',
> +'cpu frequency' => 'CPU-Frequenz',
> 'cpu frequency per' => 'CPU-Frequenz pro',
> 'cpu idle usage' => 'Leerlauf CPU-Nutzung',
> 'cpu interrupt usage' => 'Interrupt CPU-Nutzung',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 3f3e46641..3d8e3ceca 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -678,6 +678,7 @@
> 'country' => 'Country',
> 'country codes and flags' => 'Country Codes and Flags:',
> 'countrycode' => 'Code',
> +'cpu frequency' => 'CPU frequency',
> 'cpu frequency per' => 'CPU frequency per',
> 'cpu idle usage' => 'Idle CPU Usage',
> 'cpu interrupt usage' => 'Interrupt CPU Usage',
> --
> 2.16.4
prev parent reply other threads:[~2020-04-11 9:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 9:02 Peter Müller
2020-04-11 9:32 ` Michael Tremer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=035028D8-1642-40B6-A128-1744FC5E6E85@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox