From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] system.cgi: correctly translate CPU frequency
Date: Sat, 11 Apr 2020 10:32:04 +0100
Message-ID: <035028D8-1642-40B6-A128-1744FC5E6E85@ipfire.org>
In-Reply-To: <f200ab55-1680-bc38-fc15-74c9b894e22d@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0602847636089640995=="
List-Id: <development.lists.ipfire.org>

--===============0602847636089640995==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

> On 11 Apr 2020, at 10:02, Peter M=C3=BCller <peter.mueller(a)ipfire.org> wr=
ote:
>=20
> The CPU frequency diagram used the same "translation" as the CPU load,
> which was confusing. This patch introduces a dedicated translation for
> "CPU frequency", which makes things a little bit better but still does
> not solve a Deppenleerzeichen ("CPU-Frequenz Diagramm") in the German
> translation.
>=20
> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
> ---
> html/cgi-bin/system.cgi | 2 +-
> langs/de/cgi-bin/de.pl  | 1 +
> langs/en/cgi-bin/en.pl  | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/html/cgi-bin/system.cgi b/html/cgi-bin/system.cgi
> index 487ba996c..d7db9406a 100644
> --- a/html/cgi-bin/system.cgi
> +++ b/html/cgi-bin/system.cgi
> @@ -61,7 +61,7 @@ if ( $querry[0] =3D~ "cpufreq"){
> 	&Header::closebox();
>=20
> 	if ( -e "$mainsettings{'RRDLOG'}/collectd/localhost/cpufreq/cpufreq-0.rrd"=
){
> -		&Header::openbox('100%', 'center', "CPU $Lang::tr{'graph'}");
> +		&Header::openbox('100%', 'center', "$Lang::tr{'cpu frequency'} $Lang::tr=
{'graph'}");
> 		&Graphs::makegraphbox("system.cgi","cpufreq","day");
> 		&Header::closebox();
> 	}
> diff --git a/langs/de/cgi-bin/de.pl b/langs/de/cgi-bin/de.pl
> index c3702cc09..9f1768e78 100644
> --- a/langs/de/cgi-bin/de.pl
> +++ b/langs/de/cgi-bin/de.pl
> @@ -662,6 +662,7 @@
> 'country' =3D> 'Land',
> 'country codes and flags' =3D> 'L=C3=A4nder und L=C3=A4nderkennungen',
> 'countrycode' =3D> 'Kennung',
> +'cpu frequency' =3D> 'CPU-Frequenz',
> 'cpu frequency per' =3D> 'CPU-Frequenz pro',
> 'cpu idle usage' =3D> 'Leerlauf CPU-Nutzung',
> 'cpu interrupt usage' =3D> 'Interrupt CPU-Nutzung',
> diff --git a/langs/en/cgi-bin/en.pl b/langs/en/cgi-bin/en.pl
> index 3f3e46641..3d8e3ceca 100644
> --- a/langs/en/cgi-bin/en.pl
> +++ b/langs/en/cgi-bin/en.pl
> @@ -678,6 +678,7 @@
> 'country' =3D> 'Country',
> 'country codes and flags' =3D> 'Country Codes and Flags:',
> 'countrycode' =3D> 'Code',
> +'cpu frequency' =3D> 'CPU frequency',
> 'cpu frequency per' =3D> 'CPU frequency per',
> 'cpu idle usage' =3D> 'Idle CPU Usage',
> 'cpu interrupt usage' =3D> 'Interrupt CPU Usage',
> --=20
> 2.16.4


--===============0602847636089640995==--