From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH 2/2] firewall-lib.pl: Remove prefix when dealing with ipset sets.
Date: Thu, 03 Mar 2022 15:10:49 +0000
Message-ID: <03E55B40-ED91-43F2-A157-FB3BB33E33DC@ipfire.org>
In-Reply-To: <20220302194306.4110-2-stefan.schantl@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2949537766118793246=="
List-Id: <development.lists.ipfire.org>

--===============2949537766118793246==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Stefan,

Thank you for this patch. It is however already obsolete due to my changes to=
 libloc:

  https://lists.ipfire.org/pipermail/location/2022-March/000536.html

Could you please send some follow-up patches that update this to the latest n=
aming convention?

Would you also take care of packaging libloc for IPFire 2?

Best,
-Michael

> On 2 Mar 2022, at 19:43, Stefan Schantl <stefan.schantl(a)ipfire.org> wrote:
>=20
> Signed-off-by: Stefan Schantl <stefan.schantl(a)ipfire.org>
> ---
> config/firewall/firewall-lib.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/firewall/firewall-lib.pl b/config/firewall/firewall-lib=
.pl
> index f4089a3a0..7d35d5686 100644
> --- a/config/firewall/firewall-lib.pl
> +++ b/config/firewall/firewall-lib.pl
> @@ -466,7 +466,7 @@ sub get_address
> 			# Get external interface.
> 			my $external_interface =3D &get_external_interface();
>=20
> -			push(@ret, ["-m set --match-set CC_$value src", "$external_interface"]);
> +			push(@ret, ["-m set --match-set $value src", "$external_interface"]);
> 		}
>=20
> 	# Handle rule options with a location as target.
> @@ -476,7 +476,7 @@ sub get_address
> 			# Get external interface.
> 			my $external_interface =3D &get_external_interface();
>=20
> -			push(@ret, ["-m set --match-set CC_$value dst", "$external_interface"]);
> +			push(@ret, ["-m set --match-set $value dst", "$external_interface"]);
> 		}
>=20
> 	# If nothing was selected, we assume "any".
> --=20
> 2.30.2
>=20


--===============2949537766118793246==--