From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 40/50] gcc: Compile without ZSTD
Date: Wed, 23 Feb 2022 15:56:05 +0000
Message-ID: <03d22441-394c-b130-1ed0-ced929c1c6ad@ipfire.org>
In-Reply-To: <6E8123C8-D812-44C4-9A5C-35AD2FFBA05D@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============2752271652082555977=="
List-Id: <development.lists.ipfire.org>

--===============2752271652082555977==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Michael,

thanks for your reply.

Yeah, I saw the nightly builds failing across all architectures, too.

The offending patch has been revered:
https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dcommit;h=3D8fa66ce750dee06140e=
55b689a0645860e005b11

Let's hope everything compiles again _now_ ... :-)

Thanks, and best regards,
Peter M=C3=BCller


> Hello Peter,
>=20
> Could you please revert this patch again?
>=20
> Bird seems to (unconditionally) enable LTO which it shouldn=E2=80=99t. This=
 patch shouldn=E2=80=99t break LTO at all, but it does.
>=20
> Since this is not a priority right now, could you please just revert this p=
atch?
>=20
> -Michael
>=20
>> On 22 Feb 2022, at 12:51, Michael Tremer <michael.tremer(a)ipfire.org> wro=
te:
>>
>> GCC can use ZSTD to compress debugging/LTO information in binary
>> objects. However, on riscv64, compiling zstd requires libatomic which is
>> not available at this point.
>>
>> In order to make the build work, we explicitely disable ZSTD in GCC and
>> build ZSTD after libatomic is available.
>>
>> Although ZSTD offers great compression, we won't have any disadvantages
>> through this change since we do not ship any debugging information and
>> at this point in time to not use LTO.
>>
>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> ---
>> lfs/gcc | 3 ++-
>> make.sh | 2 +-
>> 2 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/lfs/gcc b/lfs/gcc
>> index f78891e24..563e94c16 100644
>> --- a/lfs/gcc
>> +++ b/lfs/gcc
>> @@ -182,7 +182,8 @@ EXTRA_CONFIG +=3D \
>> 	--disable-multilib \
>> 	--with-bugurl=3Dhttps://bugzilla.ipfire.org \
>> 	--disable-libunwind-exceptions \
>> -	--enable-gnu-unique-object
>> +	--enable-gnu-unique-object \
>> +	--without-zstd
>>
>> export XCFLAGS =3D $(CFLAGS)
>> export TCFLAGS =3D $(CFLAGS)
>> diff --git a/make.sh b/make.sh
>> index cb11b36ab..522fe8401 100755
>> --- a/make.sh
>> +++ b/make.sh
>> @@ -1079,7 +1079,6 @@ buildbase() {
>> 	lfsmake2 tzdata
>> 	lfsmake2 cleanup-toolchain
>> 	lfsmake2 zlib
>> -	lfsmake2 zstd
>> 	lfsmake2 autoconf
>> 	lfsmake2 automake
>> 	lfsmake2 libtool
>> @@ -1090,6 +1089,7 @@ buildbase() {
>> 	lfsmake2 libxcrypt
>> 	lfsmake2 file
>> 	lfsmake2 gcc
>> +	lfsmake2 zstd
>> 	lfsmake2 sed
>> 	lfsmake2 berkeley
>> 	lfsmake2 coreutils
>> --=20
>> 2.30.2
>>
>=20

--===============2752271652082555977==--