Core Update 157

Core Update 157

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1541 bytes --]

Hello,

Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).

The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.

Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.

In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.

In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?

* Fixes for #12616
* Can we finish the migration away from Python 2?
* Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
* VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?

What else are you guys working on that is ready for prime-time?

-Michael

Re: Core Update 157

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]

Hello Michael,

thanks for your message.

I am currently working on dropping all the packages and add-ons, as we discussed earlier
this month. A patchset will be ready within the next few hours, ideally before midnight,
Deo volente.

Aside from that, I do not have anything stable enough to make it into Core Update 158.

Thanks, and best regards,
Peter Müller


> Hello,
> 
> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
> 
> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
> 
> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
> 
> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
> 
> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
> 
> * Fixes for #12616
> * Can we finish the migration away from Python 2?
> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
> 
> What else are you guys working on that is ready for prime-time?
> 
> -Michael
> 

Re: Core Update 157

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2260 bytes --]

Hello,

> On 17 May 2021, at 22:28, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello Michael,
> 
> thanks for your message.
> 
> I am currently working on dropping all the packages and add-ons, as we discussed earlier
> this month. A patchset will be ready within the next few hours, ideally before midnight,
> Deo volente.

Cool. Thank you. This won’t make it into Core Update 157 because I want to allow some time for discussion.

> Aside from that, I do not have anything stable enough to make it into Core Update 158.

Thanks for letting me know :)

-Michael

> Thanks, and best regards,
> Peter Müller
> 
> 
>> Hello,
>> 
>> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
>> 
>> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
>> 
>> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
>> 
>> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
>> 
>> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
>> 
>> * Fixes for #12616
>> * Can we finish the migration away from Python 2?
>> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
>> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
>> 
>> What else are you guys working on that is ready for prime-time?
>> 
>> -Michael
>> 

Re: Core Update 157

[Peter Müller]

[-- Attachment #1: Type: text/plain, Size: 2715 bytes --]

Hello Michael,

it just occurred to me that there are two patches fixing a nasty bug in fwhosts.cgi still left in the queue:

- https://patchwork.ipfire.org/patch/4199/
- https://patchwork.ipfire.org/patch/4206/

Since fwhosts.cgi was primarily written by Alex, I asked him to review these, but have not heard anything back.

Shall we merge them anyway?

Thanks, and best regards,
Peter Müller


> Hello,
> 
>> On 17 May 2021, at 22:28, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>
>> Hello Michael,
>>
>> thanks for your message.
>>
>> I am currently working on dropping all the packages and add-ons, as we discussed earlier
>> this month. A patchset will be ready within the next few hours, ideally before midnight,
>> Deo volente.
> 
> Cool. Thank you. This won’t make it into Core Update 157 because I want to allow some time for discussion.
> 
>> Aside from that, I do not have anything stable enough to make it into Core Update 158.
> 
> Thanks for letting me know :)
> 
> -Michael
> 
>> Thanks, and best regards,
>> Peter Müller
>>
>>
>>> Hello,
>>>
>>> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
>>>
>>> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
>>>
>>> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
>>>
>>> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
>>>
>>> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
>>>
>>> * Fixes for #12616
>>> * Can we finish the migration away from Python 2?
>>> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
>>> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
>>>
>>> What else are you guys working on that is ready for prime-time?
>>>
>>> -Michael
>>>
> 

Re: Core Update 157

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 3002 bytes --]

Hello,

> On 17 May 2021, at 23:02, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> Hello Michael,
> 
> it just occurred to me that there are two patches fixing a nasty bug in fwhosts.cgi still left in the queue:
> 
> - https://patchwork.ipfire.org/patch/4199/
> - https://patchwork.ipfire.org/patch/4206/
> 
> Since fwhosts.cgi was primarily written by Alex, I asked him to review these, but have not heard anything back.

A timeout cannot be taken as an acknowledgement. Did you try getting in touch with Alex?

-Michael

> Shall we merge them anyway?
> 
> Thanks, and best regards,
> Peter Müller
> 
> 
>> Hello,
>> 
>>> On 17 May 2021, at 22:28, Peter Müller <peter.mueller(a)ipfire.org> wrote:
>>> 
>>> Hello Michael,
>>> 
>>> thanks for your message.
>>> 
>>> I am currently working on dropping all the packages and add-ons, as we discussed earlier
>>> this month. A patchset will be ready within the next few hours, ideally before midnight,
>>> Deo volente.
>> 
>> Cool. Thank you. This won’t make it into Core Update 157 because I want to allow some time for discussion.
>> 
>>> Aside from that, I do not have anything stable enough to make it into Core Update 158.
>> 
>> Thanks for letting me know :)
>> 
>> -Michael
>> 
>>> Thanks, and best regards,
>>> Peter Müller
>>> 
>>> 
>>>> Hello,
>>>> 
>>>> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
>>>> 
>>>> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
>>>> 
>>>> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
>>>> 
>>>> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
>>>> 
>>>> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
>>>> 
>>>> * Fixes for #12616
>>>> * Can we finish the migration away from Python 2?
>>>> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
>>>> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
>>>> 
>>>> What else are you guys working on that is ready for prime-time?
>>>> 
>>>> -Michael
>>>> 
>> 

Re: Core Update 157

[Adolf Belka]

[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]

Hi Michael,

I don't have anything new that I am working on that needs to go into 157. I just keep finding things that can be updated and so I update them. I am quite happy for you to decide which Core Update they should go in.

In terms of python2 the big barrier to removing python2 at some point is crda. From my investigation it requires the python2 version of M2Crypto. The python2 version of M2crypto requires the python2 versions of typing and setuptools.  All the other python2 to python3 migrations seemed to go okay.

Regards,

Adolf.

On 17/05/2021 23:23, Michael Tremer wrote:
> Hello,
>
> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
>
> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
>
> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
>
> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
>
> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
>
> * Fixes for #12616
> * Can we finish the migration away from Python 2?
> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
>
> What else are you guys working on that is ready for prime-time?
>
> -Michael

Re: Core Update 157

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2461 bytes --]

Hello,

> On 17 May 2021, at 22:52, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> I don't have anything new that I am working on that needs to go into 157. I just keep finding things that can be updated and so I update them. I am quite happy for you to decide which Core Update they should go in.

Cool.

> In terms of python2 the big barrier to removing python2 at some point is crda. From my investigation it requires the python2 version of M2Crypto. The python2 version of M2crypto requires the python2 versions of typing and setuptools.  All the other python2 to python3 migrations seemed to go okay.

I have seen your email. I just don’t manage to stay on top of my inbox at the moment. I will reply to that as soon as I can.

-Michael

> Regards,
> 
> Adolf.
> 
> On 17/05/2021 23:23, Michael Tremer wrote:
>> Hello,
>> 
>> Because there are so many things going on at the same time, I would like to start a brief main thread about the upcoming Core Update(s).
>> 
>> The original plan was to have this closed a while ago because Core Update 156 has already gone out. But then I decided to wait for a couple of smaller things until we had a security vulnerability reported which I wanted to investigate more (#12616 and #12619). It is not too bad, but I would like to ship at least a fix that is good enough to mitigate it. We might need some more time to figure out the details around the other half of the solution for this problem.
>> 
>> Now this update has become *very* large. It is the largest update we have ever had and that might break things. Therefore I do not want to merge anything more that has to go into the core system, but add-on packages are fine.
>> 
>> In fact, the build that I just pushed should be the final one, unless we find any other problems. Does anyone have anything urgent and small left? Otherwise Core Update 158 will be open as soon as 157 has hit the master branch.
>> 
>> In order to coordinate that a little bit more and have a good and hopefully brief merge window, what should be in it?
>> 
>> * Fixes for #12616
>> * Can we finish the migration away from Python 2?
>> * Drop the packages discussed at the last conference call (https://wiki.ipfire.org/devel/telco/2021-05-03)?
>> * VPNs for iOS (https://patchwork.ipfire.org/project/ipfire/list/?series=1323)?
>> 
>> What else are you guys working on that is ready for prime-time?
>> 
>> -Michael