public inbox for development@lists.ipfire.org
 help / color / mirror / Atom feed
From: Michael Tremer <michael.tremer@ipfire.org>
To: "Peter Müller" <peter.mueller@ipfire.org>
Cc: "IPFire: Development" <development@lists.ipfire.org>
Subject: Re: [PATCH] firewall: Restrict outgoing network access for Knot to DNS-related ports
Date: Tue, 25 Aug 2026 14:37:03 +0100	[thread overview]
Message-ID: <04EC2F7A-3A82-4E96-859E-7DCE447E3F2F@ipfire.org> (raw)
In-Reply-To: <8455e819-c886-45e5-88c7-d4c47e941df5@ipfire.org>

Hello,

Thank you for this patch. Very sensible adjustment.

Best,
-Michael

> On 25 Aug 2026, at 14:29, Peter Müller <peter.mueller@ipfire.org> wrote:
> 
> Since Knot and the RPZ zone sync tool only need access to destination ports
> 53 (UDP + TCP) or 853 (TCP) in case of DNS over TLS, keep their firewall
> rules constrained to these ports.
> 
> Signed-off-by: Peter Müller <peter.mueller@ipfire.org>
> ---
> src/initscripts/system/firewall | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/src/initscripts/system/firewall b/src/initscripts/system/firewall
> index a97758dc3..c7627bcab 100644
> --- a/src/initscripts/system/firewall
> +++ b/src/initscripts/system/firewall
> @@ -2,7 +2,7 @@
> ###############################################################################
> #                                                                             #
> # IPFire.org - A linux based firewall                                         #
> -# Copyright (C) 2007-2022  IPFire Team  <info@ipfire.org>                     #
> +# Copyright (C) 2007-2026  IPFire Team  <info@ipfire.org>                     #
> #                                                                             #
> # This program is free software: you can redistribute it and/or modify        #
> # it under the terms of the GNU General Public License as published by        #
> @@ -443,7 +443,9 @@ iptables_init() {
> /usr/local/bin/captivectrl
> 
> # Grant Knot Resolver access
> - iptables -A LOCAL_OUTPUT -m owner --uid-owner knot-resolver -j ACCEPT
> + iptables -A LOCAL_OUTPUT -m owner --uid-owner knot-resolver -p udp --dport  53 -j ACCEPT
> + iptables -A LOCAL_OUTPUT -m owner --uid-owner knot-resolver -p tcp --dport  53 -j ACCEPT
> + iptables -A LOCAL_OUTPUT -m owner --uid-owner knot-resolver -p tcp --dport 853 -j ACCEPT
> 
> # If a Tor relay is enabled apply firewall rules
> if [ "${TOR_RELAY_ENABLED}" = "on" -a -n "${TOR_RELAY_PORT}" ]; then
> -- 
> 2.51.0
> 



      reply	other threads:[~2026-08-25 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-25 13:29 Peter Müller
2026-08-25 13:37 ` Michael Tremer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=04EC2F7A-3A82-4E96-859E-7DCE447E3F2F@ipfire.org \
    --to=michael.tremer@ipfire.org \
    --cc=development@lists.ipfire.org \
    --cc=peter.mueller@ipfire.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox