From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject:
 Re: [PATCH] unbound-dhcp-leases-bridge: Reload unbound to import leases
Date: Thu, 13 Jul 2023 14:23:00 +0000
Message-ID: <0619527e-fc25-b3f6-b56f-d376992cab44@ipfire.org>
In-Reply-To: <20230711132932.786202-1-michael.tremer@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8914220254721285087=="
List-Id: <development.lists.ipfire.org>

--===============8914220254721285087==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Acked-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>

> This changes the old "diff" algorithm that we needed to have before
> Unbound was able to reload its own configuration.
>=20
> Now, it can do this even without dropping the cache. This should
> hopefully perform much better and be more reliable than the old way.
>=20
> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>
> ---
>  config/unbound/unbound-dhcp-leases-bridge | 52 ++++-------------------
>  1 file changed, 8 insertions(+), 44 deletions(-)
>=20
> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unb=
ound-dhcp-leases-bridge
> index e89e0446b..e9f022aff 100644
> --- a/config/unbound/unbound-dhcp-leases-bridge
> +++ b/config/unbound/unbound-dhcp-leases-bridge
> @@ -514,56 +514,19 @@ class UnboundConfigWriter(object):
>  	def __init__(self, path):
>  		self.path =3D path
> =20
> -		self._cached_leases =3D []
> -
>  	def update_dhcp_leases(self, leases):
> -		# Find any leases that have expired or do not exist any more
> -		# but are still in the unbound local data
> -		removed_leases =3D [l for l in self._cached_leases if not l in leases]
> -
> -		# Find any leases that have been added
> -		new_leases =3D [l for l in leases if l not in self._cached_leases]
> -
> -		# End here if nothing has changed
> -		if not new_leases and not removed_leases:
> -			return
> -
>  		# Write out all leases
>  		self.write_dhcp_leases(leases)
> =20
> -		# Update unbound about changes
> -		for l in removed_leases:
> -			try:
> -				for name, ttl, type, content in l.rrset:
> -					log.debug("Removing records for %s" % name)
> -					self._control("local_data_remove", name)
> -
> -			# If the lease cannot be removed we will try the next one
> -			except:
> -				continue
> -
> -			# If the removal was successful, we will remove it from the cache
> -			else:
> -				self._cached_leases.remove(l)
> -
> -		for l in new_leases:
> -			try:
> -				for rr in l.rrset:
> -					log.debug("Adding new record %s" % " ".join(rr))
> -					self._control("local_data", *rr)
> -
> -			# If the lease cannot be added we will try the next one
> -			except:
> -				continue
> +		log.debug("Reloading Unbound...")
> =20
> -			# Add lease to cache when successfully added
> -			else:
> -				self._cached_leases.append(l)
> +		# Reload the configuration without dropping the cache
> +		self._control("reload_keep_cache")
> =20
>  	def write_dhcp_leases(self, leases):
> -		with tempfile.NamedTemporaryFile(mode=3D"w", delete=3DFalse) as f:
> -			filename =3D f.name
> +		log.debug("Writing DHCP leases...")
> =20
> +		with tempfile.NamedTemporaryFile(mode=3D"w", delete=3DFalse) as f:
>  			for l in leases:
>  				for rr in l.rrset:
>  					f.write("local-data: \"%s\"\n" % " ".join(rr))
> @@ -571,7 +534,8 @@ class UnboundConfigWriter(object):
>  			# Make file readable for everyone
>  			os.fchmod(f.fileno(), stat.S_IRUSR|stat.S_IWUSR|stat.S_IRGRP|stat.S_IRO=
TH)
> =20
> -		os.rename(filename, self.path)
> +			# Move the file to its destination
> +			os.rename(f.name, self.path)
> =20
>  	def _control(self, *args):
>  		command =3D ["unbound-control"]
> @@ -585,7 +549,7 @@ class UnboundConfigWriter(object):
>  			log.critical("Could not run %s, error code: %s: %s" % (
>  				" ".join(command), e.returncode, e.output))
> =20
> -			raise
> +			raise e
> =20
> =20
>  if __name__ =3D=3D "__main__":

--===============8914220254721285087==--