From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] vnstat 2.6: Fix for lfs
Date: Sun, 12 Apr 2020 15:15:54 +0100 [thread overview]
Message-ID: <0625C429-1906-4D46-8F32-319BB3F9E9D1@ipfire.org> (raw)
In-Reply-To: <55648ee1-9c04-e82c-c65d-643a1b0c9806@ipfire.org>
[-- Attachment #1: Type: text/plain, Size: 991 bytes --]
Hi,
> On 11 Apr 2020, at 19:41, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
>
> On 11.04.2020 20:26, Michael Tremer wrote:
>> Hi,
>>
>> Yes, but this script does not contain any evaluate_retval calls after loadproc/killproc:
>>
>> https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=blob;f=src/initscripts/system/lvmetad;h=fdae39fd9c74e3950495ee54a1f6762af951fab4;hb=59b3afd07f55b93f4c96bfe63d0506494a46b5ff
>>
>> ...
>
> Current link is (I updated the one above!):
> https://git.ipfire.org/?p=people/mfischer/ipfire-2.x.git;a=blob;f=src/initscripts/system/vnstat;h=c1bb2942a897e0a4acab344c8e2c128d4542f958;hb=59b3afd07f55b93f4c96bfe63d0506494a46b5ff
So in this script, when you remove line 23 and 33, you will still see OK.
That is being printed in loadproc. evaluate_retval will now always overwrite what loadproc has printed to the right hand side of the console.
We want to see any errors here :)
-Michael
>
> Best,
> Matthias
next prev parent reply other threads:[~2020-04-12 14:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-11 14:38 Matthias Fischer
2020-04-11 15:28 ` Michael Tremer
2020-04-11 16:39 ` Matthias Fischer
2020-04-11 18:03 ` Michael Tremer
2020-04-11 18:17 ` Matthias Fischer
2020-04-11 18:21 ` Michael Tremer
2020-04-11 18:40 ` Matthias Fischer
2020-04-11 18:22 ` Matthias Fischer
2020-04-11 18:26 ` Michael Tremer
2020-04-11 18:41 ` Matthias Fischer
2020-04-12 14:15 ` Michael Tremer [this message]
2020-04-12 17:22 ` Matthias Fischer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0625C429-1906-4D46-8F32-319BB3F9E9D1@ipfire.org \
--to=michael.tremer@ipfire.org \
--cc=development@lists.ipfire.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox