Re: [PATCH 0/2] zonconf: replace the nic-names with eth... and wlan... or not?

Re: [PATCH 0/2] zonconf: replace the nic-names with eth... and wlan... or not?

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 2819 bytes --]

Hi,

I agree with both of you :)

Showing the “old” names is confusing. Numbering them again is also not helpful.

Is it better if we do not show any device name at all? Nobody needs that to decide which NIC is being assigned to what zone, right?

-Michael

> On 4 Sep 2019, at 07:49, Florian Bührle <erdlof(a)protonmail.com> wrote:
> 
> Hi Alex,
> 
> your point is absolutely correct, however there's some thought behind this: as the udev rules rename the physical interfaces to <zone>0 when the interface accesses the zone directly, it could be quite confusing if the interface is named orange0 for example and you want to assign it to blue in the CGI, even though it would work fine. 
> What do you think?
> 
> Regards
> Florian
> 
> Gesendet von ProtonMail mobile
> 
> 
> 
> -------- Original-Nachricht --------
> An 3. Sep. 2019, 23:46, Alex Koch schrieb:
> 
> Hi,
> 
> I stumbled into this when I was searching for an error in my vlan and bridge-config and want to start a discussion about if this should be changed or not.
> 
> The zoneconf.cgi contains the following code-snippet:
> 
> > # Name the physical NICs
> > # Even though they may not be really named like this, we will name them ethX or wlanX
> > my $ethcount = 0;
> > my $wlancount = 0;
> >
> > foreach (@nics) {
> > my $nic = $_->[1];
> >
> > if (-e "/sys/class/net/$nic/wireless") {
> > $_->[1] = "wlan$wlancount";
> > $_->[2] = 1;
> > $wlancount++;
> > } else {
> > $_->[1] = "eth$ethcount";
> > $ethcount++;
> > }
> > }
> 
> This renames all the nics to ethX or wlanX for the WUI. When you use any commandline tool (e.g ip addr or brctl show) the names of the NICs will mismatch with the ones shown in the WUI. Same for the assigened VLAN-IDs.
> 
> For example, one of my setups:
> 
> - WUI name --> real name
> - eth0 --> red0
> - eth1 --> eth1
> - eth2 --> orange0
> - wlan0 --> blue0
> - wlan1 --> wlan1
> 
> What is the goal of doing this? I personally think this is more confusing than useful. I would prefer to not rename the NICs. What do you think?
> 
> I attached a patch to change the naming back to the real names. Please decide to merge it or not, depending on where the discussion ends.
> 
> Secondly I created a patch to add the current output of "brctl show" and "ip addr" to the zoneconfig page. It's quite useful to have this by the hand without having to open a shell sometimes.
> 
> Regards, Alex
> 
> Alex Koch (2):
> zoneconf: Show real names of NICs in the WUI
> zoneconf: Add status output of "brctl show" and "ip addr"
> 
> html/cgi-bin/zoneconf.cgi | 34 ++++++++++++++++++++++++----------
> langs/de/cgi-bin/de.pl | 5 ++++-
> langs/en/cgi-bin/en.pl | 5 ++++-
> 3 files changed, 32 insertions(+), 12 deletions(-)
> 
> --
> 2.17.1
> 

[PATCH 0/2] zonconf: replace the nic-names with eth... and wlan... or not?

[Alex Koch]

[-- Attachment #1: Type: text/plain, Size: 1843 bytes --]

Hi,

I stumbled into this when I was searching for an error in my vlan and bridge-config and want to start a discussion about if this should be changed or not.

The zoneconf.cgi contains the following code-snippet:

> # Name the physical NICs
> # Even though they may not be really named like this, we will name them ethX or wlanX
> my $ethcount = 0;
> my $wlancount = 0;
>
> foreach (@nics) {
> 	my $nic = $_->[1];
>
> 	if (-e "/sys/class/net/$nic/wireless") {
> 		$_->[1] = "wlan$wlancount";
> 		$_->[2] = 1;
> 		$wlancount++;
> 	} else {
> 		$_->[1] = "eth$ethcount";
> 		$ethcount++;
> 	}
> }

This renames all the nics to ethX or wlanX for the WUI. When you use any commandline tool (e.g ip addr or brctl show) the names of the NICs will mismatch with the ones shown in the WUI. Same for the assigened VLAN-IDs.

For example, one of my setups:

- WUI name --> real name
- eth0 --> red0
- eth1 --> eth1
- eth2 --> orange0
- wlan0 --> blue0
- wlan1 --> wlan1

What is the goal of doing this? I personally think this is more confusing than useful. I would prefer to not rename the NICs. What do you think?

I attached a patch to change the naming back to the real names. Please decide to merge it or not, depending on where the discussion ends.

Secondly I created a patch to add the current output of "brctl show" and "ip addr" to the zoneconfig page. It's quite useful to have this by the hand without having to open a shell sometimes.

Regards, Alex


Alex Koch (2):
  zoneconf: Show real names of NICs in the WUI
  zoneconf: Add status output of "brctl show" and "ip addr"

 html/cgi-bin/zoneconf.cgi | 34 ++++++++++++++++++++++++----------
 langs/de/cgi-bin/de.pl    |  5 ++++-
 langs/en/cgi-bin/en.pl    |  5 ++++-
 3 files changed, 32 insertions(+), 12 deletions(-)

--
2.17.1