From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter =?utf-8?q?M=C3=BCller?= <peter.mueller@ipfire.org>
To: development@lists.ipfire.org
Subject: IDSv4 changes
Date: Thu, 05 May 2022 16:33:10 +0000
Message-ID: <06a35acb-9e77-fb2d-1311-a1799237dffa@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============3605772869663951878=="
List-Id: <development.lists.ipfire.org>

--===============3605772869663951878==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello Stefan,

better late than never I finally reviewed the IDSv4 changes you made, and ins=
talled the latest
tarball onto my testing machine. Everything went pretty smooth, with the only=
 exception of this
message emitted by the converter script:

> [root(a)maverick ~]# convert-ids-backend-files=20
> 5/4/2022 -- 17:37:00 - <Error> - [ERRCODE: SC_ERR_FOPEN(44)] - Failed to op=
en configuration include file /var/ipfire/suricata/suricata-used-rulesfiles.y=
aml: No such file or directory

While ignoring this message did not cause any harm in my case, could you plea=
se confirm that this
one is safe to ignore indeed?

Afterwards, I toyed around with the IDS CGI, and was unable to break it or ca=
use any unwanted
behaviour. Therefore, IDSv4 looks good to me, and I just merged this branch o=
f yours into "next",
and added all the necessary changes to Core Update 168 and its updater.

It would be great if you could have a look at https://git.ipfire.org/?p=3Dipf=
ire-2.x.git;a=3Dcommit;h=3D68725035744de0253f19e0b3550799799a44f80d
and drop me a line in case anything is still missing.

With regards to Patchwork, I assume https://patchwork.ipfire.org/project/ipfi=
re/list/?series=3D2729
is superseded by the IDSv4 changes, but
https://patchwork.ipfire.org/project/ipfire/patch/20220406192332.4865-1-stefa=
n.schantl(a)ipfire.org/
definitely is not. While I tend to agree with this patch, Michael asked for i=
ts rationale, so it
would be great if you could reply to his question.

Aside from that, many thanks for your contribution. IDSv4 really is an improv=
ement.

Thanks, and best regards,
Peter M=C3=BCller

--===============3605772869663951878==--