From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adolf Belka To: development@lists.ipfire.org Subject: Re: Core Update 147 testing Date: Mon, 06 Jul 2020 13:34:26 +0200 Message-ID: <07ae3ab4-2150-f1e4-1c91-9fc6b5fb7434@gmail.com> In-Reply-To: <5422f183-a209-476d-9919-52bf91491380@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2664817195759707205==" List-Id: --===============2664817195759707205== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Hi Michael, I managed to answer my own question. I went and looked at the Core Update 147= testing bacula install that I carried out and found a bacula file in /opt/pa= kfire/db/rootfiles/ so it does occur automatically when the add-on is install= ed. I will send the corrected bacula-9.6.5 patch file by git send-email. Regards, Adolf. On 04/07/2020 15:04, Adolf Belka wrote: > Hi Michael, > > I am nearly ready to git send-email but I have thought of another question = about something I may have missed. > > For removing all files during an uninstall there needs to be the rootfiles = list in /opt/pakfire/db/rootfiles/. > > Is this something that is done automatically when the add-on is installed o= r do I need to also add this as a command into lfs/bacula. If the latter then= where do I need to install it from. If the former then I can git send-email = what I have now. > > Regards, > > Adolf. > > On 03/07/2020 14:44, Michael Tremer wrote: >> Hi, >> >>> On 3 Jul 2020, at 12:20, Adolf Belka wrote: >>> >>> Hi Michael, >>> >>> Thanks for the information. I had missed the need to do that when I insta= lled an updated bacula as a local add-on. The whole backup file requirement i= sn't mentioned in the Wiki page on installing your own add-on. I will think a= bout maybe updating or rewriting that page using the bacula package as an exa= mple. >> Yes, it is a good idea to add it. >> >> I am not sure in what way this needs a total rewrite. >> >>> I will correct my files and submit a new patch. Do I make the patch based= on the existing Core 146 9.0.6 version (so a v3 version of the patch) or on = the Core 147 development build? >> Yes, please make the patch against the next branch in the main repository. >> >> Start with a clean branch based on origin/next and add your commits. Then = send the whole thing to the list using git send-email. >> >> If you have any questions, don=E2=80=99t hesitate to ask :) >> >> -Michael >> >>> >>> Regards, >>> >>> Adolf. >>> >>> On 03/07/2020 11:36, Michael Tremer wrote: >>>> Hi Adolf, >>>> >>>> This looks like a simple problem. >>>> >>>> The file is simply missing in the root file: >>>> >>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfiles= /packages/bacula;h=3D4ee408fc4154c56549bb7456f6e5be03791d48a2;hb=3DHEAD >>>> >>>> It should be listed there. Like here for example: >>>> >>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dconfig/rootfiles= /packages/postfix;h=3D23e1efb255ceb5636117bf2907dce637756c83e9;hb=3DHEAD >>>> >>>> lfs/bacula doesn=E2=80=99t install the file either, like Postfix does: >>>> >>>> https://git.ipfire.org/?p=3Dipfire-2.x.git;a=3Dblob;f=3Dlfs/postfix;h=3D= 6ca3b23e93946c92d967bbbd23ec57d96883856b;hb=3DHEAD >>>> >>>> You can simply copy that command from postfix (of course change it to th= e right name), add it to the root file and then submit a patch :) >>>> >>>> Best, >>>> -Michael >>>> >>>>> On 3 Jul 2020, at 00:20, Adolf Belka wrote: >>>>> >>>>> Dear All, >>>>> >>>>> I went back to a Core Update 146 system and installed the old bacula 9.= 0.6 and found that version also had no backup include file in place, although= it did exist in the config/backup/includes directory from the git clone. >>>>> >>>>> Adolf >>>>> >>>>> >>>>> On 03/07/2020 00:11, Adolf Belka wrote: >>>>>> Dear All, >>>>>> >>>>>> I have tested Core Update 147 out on my virtual ipfire test bed networ= k. >>>>>> >>>>>> I also tested out installing bacula with its new version. It installed= okay and started successfully. To test it out fully I will need to do the te= st on my production system. >>>>>> >>>>>> However I found one problem. The /var/ipfire/backup/addons/includes/ba= cula file is not there. There is no includes directory under addons and the b= acula option is not there in the backup menu in the WUI. >>>>>> >>>>>> Probably something I did wrong in how I did my patch but I don't know = what the problem is. The patch included the config/backup/includes/bacula fil= e. Could someone figure out what the problem is. >>>>>> >>>>>> Apart from the problem with the bacula addon backup option not being p= resent everything else on my testbed with update 147 is working fine, althoug= h it is not a complicated setup. Just red, green, blue and orange but no othe= r options yet. >>>>>> >>>>>> Adolf. >>>>>> --===============2664817195759707205==--