Re: 'resolv' => 'Resolv-Retry', = Obsolete?

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[ummeegge]

[-- Attachment #1: Type: text/plain, Size: 3767 bytes --]

Hi Matthias,
the first and important one, i made some more stuff on that script (forgot to delete the unused polish strings) and have added also a check after deletion if strings could not be deleted. Now it takes a only little longer :-)=) but it might be also a little more user-friendly…
Updated script can be found in here --> https://raw.githubusercontent.com/ummeegge/scripts/master/langsCleaner.sh .

> 
> Absolutely: Thanks! Woah!
> 
> Funny script comments - you don't need some manager or agent? ;-)

your welcome, fun makes live sometimes a little friendlier :-) and sure i need one, what agency can you manage ;D ...

> In the meantime I've found that 'chpasswd.cgi', 'conf.cgi', 'status'cgi'
> and 'calls.cgi' (the latter three are from 'asterisk') work with
> "$tr{'". In these files I found strings like this one:
> 
> ...
> if ($cgiparams{'SUBMIT'} eq $tr{'advproxy chgwebpwd change password'})
> ...
> 
> No Lang::tr{' but $tr{'

Yes true there are some older versions in the CGIs but this should be no problem in that manner here for the script i think.
As a beneath one i have fixed the chpasswd.cgi longer time ago --> http://git.ipfire.org/?p=people/ummeegge/ipfire-2.x.git;a=commit;h=3418f9c38931c8ebd23aa619ed2fccfc16c71d40 which has been also checked by a user in the forum --> http://forum.ipfire.org/viewtopic.php?t=14148 , but it seems to be forgotten…

> I see. Perhaps we could just change entries with '/', to avoid problems
> in the future. I'll look at it during the next days.

Not sure about that, cause this appears to be problematic only for my fast humble script (and the deletion via sed cause "?" or "|" do not work) .

> Thanks again, I'll take some test runs here and write back.


O.K. .

> Funny, what just ONE obsolete string can start...


Indeed.

Greetings,

Erik

Am 05.02.2017 um 20:33 schrieb Matthias Fischer <matthias.fischer(a)ipfire.org>:

> On 05.02.2017 19:10, ummeegge wrote:
>> Hi Matthias,
> 
> Hi,
> 
> ...
> [Lots of stuff to find and delete the unused translation strings]
> ...
> 
> Absolutely: Thanks! Woah!
> 
> Funny script comments - you don't need some manager or agent? ;-)
> 
>> ...
>> an update-lang-cache is included in the script. Have tested it a little in the WUI and haven´t found currently some problems without all that entries...
> 
> In the meantime I've found that 'chpasswd.cgi', 'conf.cgi', 'status'cgi'
> and 'calls.cgi' (the latter three are from 'asterisk') work with
> "$tr{'". In these files I found strings like this one:
> 
> ...
> if ($cgiparams{'SUBMIT'} eq $tr{'advproxy chgwebpwd change password'})
> ...
> 
> No Lang::tr{' but $tr{'
> 
>> ...
>> 
>> Me too but this one --> https://github.com/ummeegge/scripts/blob/master/langsCleaner.sh needed about 25 Minutes here to compare, sort them out and delete them for each language. Possibly you will get an "sed: -e expression #1, char 15: unterminated `s' command" for each language, this is because an entry which includes "/" , i think this one --> "'ls_free/swan' => 'VPN:'," is responsible for that, haven´t found in the fast a better way to solve that ;-).
> 
> I see. Perhaps we could just change entries with '/', to avoid problems
> in the future. I'll look at it during the next days.
> 
>> If you want to go for a checkout, i might be better to backup you existing language files for a testing round.
> 
> No problem, a testmachine with Core 10X is always in reach.
> 
>> Possibly the script is way to overdosed but may it helps.
> 
> If it works, its ok for this. ;-)
> 
> Thanks again, I'll take some test runs here and write back.
> 
> Funny, what just ONE obsolete string can start...
> 
> Best,
> Matthias
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]

On 06.02.2017 16:26, ummeegge wrote:
> Hi Matthias,

Hi Erik,

> the first and important one, i made some more stuff on that script (forgot to delete the unused polish strings) and have added also a check after deletion if strings could not be deleted. Now it takes a only little longer :-)=) but it might be also a little more user-friendly…

Besides, you're acting in the future already: "$date: 03.05.2017"!? ;-))

> Updated script can be found in here --> https://raw.githubusercontent.com/ummeegge/scripts/master/langsCleaner.sh .

Thanks! - downloaded. As soon as I "have my hands free", I'll test this.
A week of work has started, and "she seems to be kind of bad-tempered"...

Some thoughts:
I saw, your script uses "grep -FR" to build the string lists, so that
the *.dat-files in '/srv/web/ipfire/cgi-bin/logs.cgi' are included in
the search!?

What about the strings in '/var/ipfire/addon-lang/*.pl'?

Best,
Matthias

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[ummeegge]

[-- Attachment #1: Type: text/plain, Size: 2347 bytes --]

Good morning Matthias,
i have found some other files which i have missed in the check. I recognized it as i checked the OpenVPN Net-to-Net Statistics in netovpnsrv.cgi where the the descriptions

Incoming Traffic
Incoming Overhead
Incoming Compression
Outgoing Traffic
Outgoing Overhead
Outgoing compression

has also been reverted. The variables aren´t located in the CGIs nor in the menu directory, the graphs.pl is responsible for that. I decided then to make a walk through IPFires Github and have searched for $Lang and found some other locations. Have updated the script now, you can find the changes as before in here --> https://github.com/ummeegge/scripts/blob/master/langsCleaner.sh , the script needs on my JNC9C now 43 minutes, may too much checked files but better then not enough.

Regarding the addon langs (possibly in general), it might be may an idea to check them also in the development chroot environment where all addons are already present ? As i can see it concerns only Guardian and the Squid Accounting Feature (WIO also but this is currently no official IPFire Addon).

This all will needs surely a deeper look.

Greetings,

Erik


Am 06.02.2017 um 21:01 schrieb Matthias Fischer <matthias.fischer(a)ipfire.org>:

> On 06.02.2017 20:50, ummeegge wrote:
>> Hi Matthias,
>> 
>>> Besides, you're acting in the future already: "$date: 03.05.2017"!? ;-))
>> oh, possibly it is just warmer then ?! My bad sorry...
> 
> No problem - we're just a few steps ahead of the others. ;-)
> 
>>> A week of work has started, and "she seems to be kind of bad-tempered"…
>> Looks here very similar.
> 
> *sigh*
> 
>>> Some thoughts:
>>> I saw, your script uses "grep -FR" to build the string lists, so that
>>> the *.dat-files in '/srv/web/ipfire/cgi-bin/logs.cgi' are included in
>>> the search!?
>> Yes this was also an intend.
> 
> Ok. Good. ;-)
> 
>>> What about the strings in '/var/ipfire/addon-lang/*.pl'?
>> This one i haven´t recognize until now, good that you mentioned it, may this directory can be used in the same way then the others ?!
> 
> I think so, but will have a look at the corresponding CGI-files.
> Otherwise I fear that changed or obsolete strings from these files may
> occur again.
> 
>> Feel greeted,
> 
> You're welcome!
> 
> Best,
> Matthias
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 3047 bytes --]

Hi Erik,

On 07.02.2017 10:52, ummeegge wrote:
> Good morning Matthias,

[Good morning Erik, - at this time I had already been busy for ~6 hours,
*sigh* ;-) ]

> i have found some other files which i have missed in the check. I recognized it as i checked the OpenVPN Net-to-Net Statistics in netovpnsrv.cgi where the the descriptions

I thought that we missed some files...

> Incoming Traffic
> Incoming Overhead
> Incoming Compression
> Outgoing Traffic
> Outgoing Overhead
> Outgoing compression
> 
> has also been reverted. The variables aren´t located in the CGIs nor in the menu directory, the graphs.pl is responsible for that. I decided then to make a walk through IPFires Github and have searched for $Lang and found some other locations. Have updated the script now, you can find the changes as before in here --> https://github.com/ummeegge/scripts/blob/master/langsCleaner.sh , the script needs on my JNC9C now 43 minutes, may too much checked files but better then not enough.

ACK.

> Regarding the addon langs (possibly in general), it might be may an idea to check them also in the development chroot environment where all addons are already present?

Yep. Perhaps I have some time to dig into this on weekend. For now, days
are full... ;-(

If the langs would be checked directly in the development environment,
there is the chance to get them all and check all at once.

As i can see it concerns only Guardian and the Squid Accounting Feature
(WIO also but this is currently no official IPFire Addon).

WIO should become official, IMHO. It should be included and dealt with.
(Beware of my english...: Also, ich meine - Ja, wir sollten da halt auch
ein Auge drauf haben).

> This all will needs surely a deeper look.

As written: ACK! ;-)

> 
> Greetings,
> 
> Erik
> 
> 
> Am 06.02.2017 um 21:01 schrieb Matthias Fischer <matthias.fischer(a)ipfire.org>:
> 
>> On 06.02.2017 20:50, ummeegge wrote:
>>> Hi Matthias,
>>> 
>>>> Besides, you're acting in the future already: "$date: 03.05.2017"!? ;-))
>>> oh, possibly it is just warmer then ?! My bad sorry...
>> 
>> No problem - we're just a few steps ahead of the others. ;-)
>> 
>>>> A week of work has started, and "she seems to be kind of bad-tempered"…
>>> Looks here very similar.
>> 
>> *sigh*
>> 
>>>> Some thoughts:
>>>> I saw, your script uses "grep -FR" to build the string lists, so that
>>>> the *.dat-files in '/srv/web/ipfire/cgi-bin/logs.cgi' are included in
>>>> the search!?
>>> Yes this was also an intend.
>> 
>> Ok. Good. ;-)
>> 
>>>> What about the strings in '/var/ipfire/addon-lang/*.pl'?
>>> This one i haven´t recognize until now, good that you mentioned it, may this directory can be used in the same way then the others ?!
>> 
>> I think so, but will have a look at the corresponding CGI-files.
>> Otherwise I fear that changed or obsolete strings from these files may
>> occur again.
>> 
>>> Feel greeted,
>> 
>> You're welcome!
>> 
>> Best,
>> Matthias
>> 
> 

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[ummeegge]

[-- Attachment #1: Type: text/plain, Size: 3606 bytes --]

Hi Matthias,

> [Good morning Erik, - at this time I had already been busy for ~6 hours,
> *sigh* ;-) ]

and two hours before i went to sleep ;-) , puhh the whole live is work.

> 
>> i have found some other files which i have missed in the check. I recognized it as i checked the OpenVPN Net-to-Net Statistics in netovpnsrv.cgi where the the descriptions
> 
> I thought that we missed some files…

Yes had/have that feeling too.

> 
>> Incoming Traffic
>> Incoming Overhead
>> Incoming Compression
>> Outgoing Traffic
>> Outgoing Overhead
>> Outgoing compression
>> 
>> has also been reverted. The variables aren´t located in the CGIs nor in the menu directory, the graphs.pl is responsible for that. I decided then to make a walk through IPFires Github and have searched for $Lang and found some other locations. Have updated the script now, you can find the changes as before in here --> https://github.com/ummeegge/scripts/blob/master/langsCleaner.sh , the script needs on my JNC9C now 43 minutes, may too much checked files but better then not enough.
> 
> ACK.
> 
>> Regarding the addon langs (possibly in general), it might be may an idea to check them also in the development chroot environment where all addons are already present?
> 
> Yep. Perhaps I have some time to dig into this on weekend. For now, days
> are full... ;-(

No problem at all, it was just a support for your intend.

> 
> If the langs would be checked directly in the development environment,
> there is the chance to get them all and check all at once.
> 
> As i can see it concerns only Guardian and the Squid Accounting Feature
> (WIO also but this is currently no official IPFire Addon).
> 
> WIO should become official, IMHO. It should be included and dealt with.
> (Beware of my english...: Also, ich meine - Ja, wir sollten da halt auch
> ein Auge drauf haben).

Klar können wir machen.
I tried that already and have found also there not used strings but i´am currently not sure if 1) really got all files and 2) if the development in those addons are finished ?! So the possibility might there that some strings are used further?! May both Stefans and Alexander do have also some infos for this.

> 
>> This all will needs surely a deeper look.
> 
> As written: ACK! ;-)

> Greetings,

> Erik


>> 
>> 
>> Am 06.02.2017 um 21:01 schrieb Matthias Fischer <matthias.fischer(a)ipfire.org>:
>> 
>>> On 06.02.2017 20:50, ummeegge wrote:
>>>> Hi Matthias,
>>>> 
>>>>> Besides, you're acting in the future already: "$date: 03.05.2017"!? ;-))
>>>> oh, possibly it is just warmer then ?! My bad sorry...
>>> 
>>> No problem - we're just a few steps ahead of the others. ;-)
>>> 
>>>>> A week of work has started, and "she seems to be kind of bad-tempered"…
>>>> Looks here very similar.
>>> 
>>> *sigh*
>>> 
>>>>> Some thoughts:
>>>>> I saw, your script uses "grep -FR" to build the string lists, so that
>>>>> the *.dat-files in '/srv/web/ipfire/cgi-bin/logs.cgi' are included in
>>>>> the search!?
>>>> Yes this was also an intend.
>>> 
>>> Ok. Good. ;-)
>>> 
>>>>> What about the strings in '/var/ipfire/addon-lang/*.pl'?
>>>> This one i haven´t recognize until now, good that you mentioned it, may this directory can be used in the same way then the others ?!
>>> 
>>> I think so, but will have a look at the corresponding CGI-files.
>>> Otherwise I fear that changed or obsolete strings from these files may
>>> occur again.
>>> 
>>>> Feel greeted,
>>> 
>>> You're welcome!
>>> 
>>> Best,
>>> Matthias
>>> 
>> 
> 


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 842 bytes --]

'resolv' => 'Resolv-Retry', = Obsolete?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 230 bytes --]

Hi,

...speaking about typos: ;-)

Can anybody tell me for what is the translation...

'resolv' => 'Resolv-Retry'

...good for?

I can't find an appropriate "Lang::tr"-translation command. Is this
string obsolete?

Best,
Matthias

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[IT Superhack]

[-- Attachment #1: Type: text/plain, Size: 829 bytes --]

Hello Matthias,

as far as I am aware, there are a lot of unused translated
strings (and of untranslated used) which seem to be listed in
doc/language_issues.[language]

Example:
http://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=doc/language_issues.en;h=f2b6eb7b4aa68fde7a0d14594b5bd96d842fba85;hb=f2b6eb7b4aa68fde7a0d14594b5bd96d842fba85

It seems like some strings are obsolete and can be safely
deleted - but I don't know for sure.

Thanks for caring about #10972 and #11271.

Best regards,
Timmothy Wilson

Matthias Fischer:
> Hi,
> 
> ...speaking about typos: ;-)
> 
> Can anybody tell me for what is the translation...
> 
> 'resolv' => 'Resolv-Retry'
> 
> ...good for?
> 
> I can't find an appropriate "Lang::tr"-translation command. Is this
> string obsolete?
> 
> Best,
> Matthias
> 



[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

Re: 'resolv' => 'Resolv-Retry', = Obsolete?

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1696 bytes --]

Hi Timmothy,

I'm a ~bit puzzled, to say the least.

Is this right or is someone kidding me?

Unused translation strings:
de.pl: 669
en.pl: 775
es.pl: 620
fr.pl: 630
it.pl: 697
nl.pl: 693
pl.pl: 620
ru.pl: 621
tr.pl: 705

For a start:
Why not delete these unused entries!?

I'm not so good in bash-programming, but how about something like this:

UNUSED_STRINGS=(
 '[STRING_FROM_LANGUAGE_ISSUES_XY]'
 '[NEXT_STRING...]'
 '[NEXT_STRING...]'
.
.
.

for i in ${UNUSED_STRINGS[@]}; do
	[SOME_SED_AND_GREP_COMMANDS{i}_TO_DELETE_UNUSED_ENTRIES_LINE_BY_LINE_FROM_XY.PL_FILES_ONE_BY_ONE]
.
.
.

I'd do it "one by one" but this is a bit too much for a hand job... ;-))

Ideas and programming examples are welcome!

Best,
Matthias


On 04.02.2017 17:32, IT Superhack wrote:
> Hello Matthias,
> 
> as far as I am aware, there are a lot of unused translated
> strings (and of untranslated used) which seem to be listed in
> doc/language_issues.[language]
> 
> Example:
> http://git.ipfire.org/?p=ipfire-2.x.git;a=blob;f=doc/language_issues.en;h=f2b6eb7b4aa68fde7a0d14594b5bd96d842fba85;hb=f2b6eb7b4aa68fde7a0d14594b5bd96d842fba85
> 
> It seems like some strings are obsolete and can be safely
> deleted - but I don't know for sure.
> 
> Thanks for caring about #10972 and #11271.
> 
> Best regards,
> Timmothy Wilson
> 
> Matthias Fischer:
>> Hi,
>> 
>> ...speaking about typos: ;-)
>> 
>> Can anybody tell me for what is the translation...
>> 
>> 'resolv' => 'Resolv-Retry'
>> 
>> ...good for?
>> 
>> I can't find an appropriate "Lang::tr"-translation command. Is this
>> string obsolete?
>> 
>> Best,
>> Matthias
>> 
> 
>