Re: [PATCH 2/2] Tell pppd not to ask for IPv6 addresses during dial-up

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1794 bytes --]

Hello,

> On 7 Jul 2021, at 20:49, Peter Müller <peter.mueller(a)ipfire.org> wrote:
> 
> pppd 2.4.9 supports IPv6 and asks for an IPv6 configuration by default.
> Setting the received prefix in the kernel will never work, however, as
> the rest of IPFire 2.x does not support IPv6.
> 
> pppd notices the ISP about this, and at least Otenet (GR) and British
> Telecom (several countries) decide to close a dial-up connection then.
> German DTAG seems to ignore such errors silently.
> 
> This patch adds an option to the pppd call to prevent asking for an
> IPv6 configuration, hence avoiding this errors.
> 
> To apply this patch, it is necessary to ship ppp 2.4.9 again. Since I
> have no access to a testing machine behind an ISP supporting IPv6, this
> patch unfortunately is untested.

In general, but especially for such critical things, this is unacceptable.

Please look for someone who can test this.

> 
> Fixes: #12651
> 
> Signed-off-by: Peter Müller <peter.mueller(a)ipfire.org>
> ---
> src/initscripts/networking/red | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/initscripts/networking/red b/src/initscripts/networking/red
> index ca0a8ae58..56f8ebb66 100644
> --- a/src/initscripts/networking/red
> +++ b/src/initscripts/networking/red
> @@ -410,7 +410,7 @@ case "${1}" in
> 			### Standard PPP options we always use
> 			#
> 			PPP_STD_OPTIONS="$PLUGOPTS usepeerdns defaultroute noipdefault noauth"
> -			PPP_STD_OPTIONS+=" default-asyncmap hide-password nodetach"
> +			PPP_STD_OPTIONS+=" default-asyncmap hide-password nodetach noipv6"
> 			PPP_STD_OPTIONS+=" noaccomp nodeflate nopcomp novj novjccomp"
> 			PPP_STD_OPTIONS+=" nobsdcomp user ${USERNAME} lcp-echo-interval 20"
> 			PPP_STD_OPTIONS+=" lcp-echo-failure 5 ${AUTH}"
> -- 
> 2.26.2