From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH] cleanfs: Clear /var/tmp on boot as well
Date: Tue, 01 Mar 2022 10:56:33 +0000
Message-ID: <0C30EA46-22A6-4C87-B2E8-A26636AE2021@ipfire.org>
In-Reply-To: <0859f5b2a9dce90dd0e5fef01c9608856eef5787.camel@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============8719360989704035547=="
List-Id: <development.lists.ipfire.org>

--===============8719360989704035547==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello everyone,

I agree with Paul and Stefan here. We should move things out of there first b=
efore we add this directory to the tidy up at boot time.

Who would like to grab this and work on this?

-Michael

> On 28 Feb 2022, at 18:48, Stefan Schantl <stefan.schantl(a)ipfire.org> wrot=
e:
>=20
> Hello Peter, Hello List,
>=20
> I have to decline this patch because the IDS system currently stores
> the downloaded tarballs (which contains the rules of a provider) in
> that directory.
>=20
> Each time the ruleset is altered or updated, these tarballs will be
> decompressed and the required files are extracted from them.
>=20
> So cleaning up this directory, would remove the tarballs and currently
> breaks the entire IDS.
>=20
> We might have to think about keeping this tarballs or to move them to a
> different (better) location.
>=20
> Best regards,
>=20
> -Stefan
>> Similar to /tmp/, there is no reason to keep any leftovers in
>> /var/tmp,
>> nor can any application expect content placed there to be persistent.
>>=20
>> On several IPFire installations I have access to, this would remove
>> quite some clutter accumulated in /var/tmp over the years.
>>=20
>> Signed-off-by: Peter M=C3=BCller <peter.mueller(a)ipfire.org>
>> ---
>>  src/initscripts/system/cleanfs | 5 +++++
>>  1 file changed, 5 insertions(+)
>>=20
>> diff --git a/src/initscripts/system/cleanfs
>> b/src/initscripts/system/cleanfs
>> index d1cbb2547..f315682ce 100644
>> --- a/src/initscripts/system/cleanfs
>> +++ b/src/initscripts/system/cleanfs
>> @@ -117,6 +117,11 @@ case "${1}" in
>>                 find . -xdev -mindepth 1 ! -name lost+found \
>>                         -delete || failed=3D1
>> =20
>> +               boot_mesg -n " /var/tmp" ${NORMAL}
>> +               cd /var/tmp &&
>> +               find . -xdev -mindepth 1 ! -name lost+found \
>> +                       -delete || failed=3D1
>> +
>>                 boot_mesg -n " /var/ipfire/dhcp" ${NORMAL}
>>                 cd /var/ipfire/dhcpc/ && find . -name "*.pid" -exec
>> rm -f {} \; || failed=3D1
>>                 cd /var/ipfire/dhcpc/ && find . -name "*.cache" -exec
>> rm -f {} \; || failed=3D1
>=20
>=20


--===============8719360989704035547==--