Re: vnstat 2.6 - (was: Re: [PATCH] tmux: Update to 3.1)

Re: vnstat 2.6 - (was: Re: [PATCH] tmux: Update to 3.1)

[Michael Tremer]

[-- Attachment #1: Type: text/plain, Size: 1344 bytes --]

Hi,

> On 25 Apr 2020, at 12:26, Matthias Fischer <matthias.fischer(a)ipfire.org> wrote:
> 
> Hi Michael,
> 
> On 25.04.2020 10:07, Michael Tremer wrote:
>> Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>
>> 
>> Thank you!
>> 
>> -Michael
>> 
>>> ...
> 
> No problem - it just came my way... ;-)
> 
> Besides: I'm thinking about the (8?) update patches for 'vnstatn 2.6'.
> 
> These are quite a few, because - as you know - it took me some time to
> get the initscript right. And one commit
> (https://patchwork.ipfire.org/patch/2936/) even has the wrong subject.
> 
> Nevertheless, its running without problems since then. Today I deleted
> the no longer needed files from '/var/log/vnstat/' ('.blue0', '.green0',
> '.red0'). The new file, 'vnstat.db' takes about 250KB at the moment and
> is staying there.

It is best if you write these things as a response to the original patch, because they will then appear in the history of patchwork.

But in general, I would recommend that this is being merged into next and we test it with more users.

> But: should I send a new patch series for this update?

Why? To clean up the mess? I would leave this for Arne. If he can work it out then not. Otherwise, a new patch series is probably the easier.

Best,
-Michael

> 
> Best,
> 
> Matthias

Re: vnstat 2.6 -

[Matthias Fischer]

[-- Attachment #1: Type: text/plain, Size: 1148 bytes --]

Hi,

On 27.04.2020 14:13, Michael Tremer wrote:
> Hi,
> 
>> ...
>> 
>> Besides: I'm thinking about the (8?) update patches for 'vnstatn 2.6'.
>> 
>> These are quite a few, because - as you know - it took me some time to
>> get the initscript right. And one commit
>> (https://patchwork.ipfire.org/patch/2936/) even has the wrong subject.
>> 
>> Nevertheless, its running without problems since then. Today I deleted
>> the no longer needed files from '/var/log/vnstat/' ('.blue0', '.green0',
>> '.red0'). The new file, 'vnstat.db' takes about 250KB at the moment and
>> is staying there.
> 
> It is best if you write these things as a response to the original patch, because they will then appear in the history of patchwork.
> 
> But in general, I would recommend that this is being merged into next and we test it with more users.
> 
>> But: should I send a new patch series for this update?
> 
> Why? To clean up the mess? I would leave this for Arne. If he can work it out then not. Otherwise, a new patch series is probably the easier.
> 
> Best,
> -Michael
> ...

Ok, I'll let Arne decide.

Best,
Matthias