From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Tremer To: development@lists.ipfire.org Subject: Re: [PATCH] updatexlrator.cgi: Fix Bug 10477 - Update Accelerator disk usage statistics are very cramped in 2.15 beta1 Date: Wed, 11 Aug 2021 12:49:05 +0200 Message-ID: <0E8E492C-F451-41F3-8F44-57B1B56A6977@ipfire.org> In-Reply-To: <20210809203253.59446-1-adolf.belka@ipfire.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1087437918260132172==" List-Id: --===============1087437918260132172== Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Could I have a screenshot of this, please? -Michael > On 9 Aug 2021, at 22:32, Adolf Belka wrote: >=20 > - This bug has been open for a long time and is still valid. The Cache stat= istics on > the Update accelerator configuration page are jammed closely together mak= ing it > not so easy to see what the numbers are. > - Implemented similar approach as used on the Memory table section of the M= emory > information page. > - Installed on vm testbed machine and confirmed to provide the desired layo= ut. >=20 > Tested-by Adolf Belka > Signed-off-by: Adolf Belka > --- > html/cgi-bin/updatexlrator.cgi | 58 +++++++++++++++++++--------------- > 1 file changed, 32 insertions(+), 26 deletions(-) >=20 > diff --git a/html/cgi-bin/updatexlrator.cgi b/html/cgi-bin/updatexlrator.cgi > index 9cfe08f4e..deead7d79 100644 > --- a/html/cgi-bin/updatexlrator.cgi > +++ b/html/cgi-bin/updatexlrator.cgi > @@ -722,15 +722,18 @@ unless ($numfiles) { print "$Lang::tr{'updxlrtr em= pty repository'}\n
=20 > print < > - > + > + > + >
$Lang::tr{'updxlrtr disk usage'}
$Lang::tr{'updxlrtr disk usage'}
> - > +
> > - > - > - > - > + > + > + > + > + > + > > END > ; > @@ -745,17 +748,17 @@ my ($device,$size,$used,$free,$percent,$mount) =3D sp= lit(' ',$dfstr); >=20 > print < > - > - > - > - > - > + > + > + > + > - > + > >
$Lang::tr{'updxlrtr cache dir'} > -$Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percentage'}= $Lang::tr{'updxlrtr cache dir'}= $Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percenta= ge'}
[$repository]$size$used$free > +[$repository]$size$used$free > END > ; > &percentbar($percent); > print < $percent$percent
> END > @@ -1015,15 +1018,18 @@ unless (@repositoryfiles) { print "$Lang::tr{'up= dxlrtr empty repository'} >=20 > print < > - > + > + > + >
$Lang::tr{'updxlrtr disk usage'}
$Lang::tr{'updxlrtr disk usage'}
> - > +
> > - > - > - > - > + > + > + > + > + > + > > END > ; > @@ -1038,17 +1044,17 @@ my ($device,$size,$used,$free,$percent,$mount) =3D = split(' ',$dfstr); >=20 > print < > - > - > - > - > - > + > + > + > + > - > + > >
$Lang::tr{'updxlrtr cache dir'} > -$Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percentage'}= $Lang::tr{'updxlrtr cache dir'}= $Lang::tr{'size'}$Lang::tr{'used'}$Lang::tr{'free'}$Lang::tr{'percenta= ge'}
[$repository]$size$used$free > +[$repository]$size$used$free > END > ; > &percentbar($percent); > print < $percent$percent
> END > --=20 > 2.32.0 >=20 --===============1087437918260132172==--