Re: [PATCH 2/4] unbound-dhcp-leases-bridge: Fix typo

[Michael Tremer <michael.tremer@ipfire.org>]

[-- Attachment #1: Type: text/plain, Size: 1678 bytes --]

I felt that “an” was correct, too. But only when I say it out loud :)

I am happy to have this patch dropped.

> On 21 Oct 2024, at 18:14, Nick Howitt <nick(a)howitts.co.uk> wrote:
> 
> Technically, I think this update is incorrect and "an" is correct - https://www.reddit.com/r/grammar/comments/riql6s/a_or_an_before_acronym_that_is_pronounced_with_a/ and https://www.grammar.com/a-vs-an-when-to-use. But TBH, I really don't think it is too important.
> 
> Nick
> 
> 
> On 21/10/2024 17:44, Bernhard Bitsch wrote:
>> 
>> Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org> 
>> 
>> Am 21.10.2024 um 18:38 schrieb Michael Tremer:
>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org> 
>>> --- 
>>>   config/unbound/unbound-dhcp-leases-bridge | 4 ++-- 
>>>   1 file changed, 2 insertions(+), 2 deletions(-) 
>>> 
>>> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/unbound-dhcp-leases-bridge 
>>> index bc944a073..2cbdaa004 100644 
>>> --- a/config/unbound/unbound-dhcp-leases-bridge 
>>> +++ b/config/unbound/unbound-dhcp-leases-bridge 
>>> @@ -279,9 +279,9 @@ class UnboundDHCPLeasesBridge(object): 
>>>           self.unbound.update_dhcp_leases([l for l in self.leases if not l.has_expired()]) 
>>>         def _add_lease(self, lease): 
>>> -        # Skip leases without an FQDN 
>>> +        # Skip leases without a FQDN 
>>>           if not lease.fqdn: 
>>> -            log.debug("Skipping lease without an FQDN: %s" % lease) 
>>> +            log.debug("Skipping lease without a FQDN: %s" % lease) 
>>>               return 
>>>             # Skip any leases that also are a static host
>> 
>