From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/4] unbound-dhcp-leases-bridge: Fix typo
Date: Mon, 21 Oct 2024 18:15:07 +0100
Message-ID: <0F0D8334-16E4-4944-B4B4-B1B3743A9AA2@ipfire.org>
In-Reply-To: <3b1760d6-2519-4a2d-874a-e2e6f0453027@howitts.co.uk>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============6916989954968006272=="
List-Id: <development.lists.ipfire.org>

--===============6916989954968006272==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

I felt that =E2=80=9Can=E2=80=9D was correct, too. But only when I say it out=
 loud :)

I am happy to have this patch dropped.

> On 21 Oct 2024, at 18:14, Nick Howitt <nick(a)howitts.co.uk> wrote:
>=20
> Technically, I think this update is incorrect and "an" is correct - https:/=
/www.reddit.com/r/grammar/comments/riql6s/a_or_an_before_acronym_that_is_pron=
ounced_with_a/ and https://www.grammar.com/a-vs-an-when-to-use. But TBH, I re=
ally don't think it is too important.
>=20
> Nick
>=20
>=20
> On 21/10/2024 17:44, Bernhard Bitsch wrote:
>>=20
>> Reviewed-by: Bernhard Bitsch <bbitsch(a)ipfire.org>=20
>>=20
>> Am 21.10.2024 um 18:38 schrieb Michael Tremer:
>>> Signed-off-by: Michael Tremer <michael.tremer(a)ipfire.org>=20
>>> ---=20
>>>   config/unbound/unbound-dhcp-leases-bridge | 4 ++--=20
>>>   1 file changed, 2 insertions(+), 2 deletions(-)=20
>>>=20
>>> diff --git a/config/unbound/unbound-dhcp-leases-bridge b/config/unbound/u=
nbound-dhcp-leases-bridge=20
>>> index bc944a073..2cbdaa004 100644=20
>>> --- a/config/unbound/unbound-dhcp-leases-bridge=20
>>> +++ b/config/unbound/unbound-dhcp-leases-bridge=20
>>> @@ -279,9 +279,9 @@ class UnboundDHCPLeasesBridge(object):=20
>>>           self.unbound.update_dhcp_leases([l for l in self.leases if not =
l.has_expired()])=20
>>>         def _add_lease(self, lease):=20
>>> -        # Skip leases without an FQDN=20
>>> +        # Skip leases without a FQDN=20
>>>           if not lease.fqdn:=20
>>> -            log.debug("Skipping lease without an FQDN: %s" % lease)=20
>>> +            log.debug("Skipping lease without a FQDN: %s" % lease)=20
>>>               return=20
>>>             # Skip any leases that also are a static host
>>=20
>=20


--===============6916989954968006272==--