From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michael Tremer <michael.tremer@ipfire.org>
To: development@lists.ipfire.org
Subject: Re: [PATCH 2/2] libidn2: Required for elinks in place of libidn
Date: Mon, 18 Nov 2024 20:03:35 +0000
Message-ID: <0F31B671-E900-4B20-A202-FF3A4620409B@ipfire.org>
In-Reply-To: <20241115213720.899284-2-adolf.belka@ipfire.org>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="===============9157960133617452484=="
List-Id: <development.lists.ipfire.org>

--===============9157960133617452484==
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable

Hello,

This looks good to me:

  Reviewed-by: Michael Tremer <michael.tremer(a)ipfire.org>

I also checked what is currently linking against the old version of libidn: k=
dig and Ghostscript.

kdig can be built with libidn2 as well, and I believe that Ghostscript is on =
the list if being dropped with CUPS, if so, we should be able to drop the old=
er version of libidn.

-Michael

> On 15 Nov 2024, at 21:37, Adolf Belka <adolf.belka(a)ipfire.org> wrote:
>=20
> Signed-off-by: Adolf Belka <adolf.belka(a)ipfire.org>
> ---
> config/rootfiles/common/libidn2 |  7 +++
> lfs/libidn2                     | 82 +++++++++++++++++++++++++++++++++
> make.sh                         |  1 +
> 3 files changed, 90 insertions(+)
> create mode 100644 config/rootfiles/common/libidn2
> create mode 100644 lfs/libidn2
>=20
> diff --git a/config/rootfiles/common/libidn2 b/config/rootfiles/common/libi=
dn2
> new file mode 100644
> index 000000000..45a4c84ea
> --- /dev/null
> +++ b/config/rootfiles/common/libidn2
> @@ -0,0 +1,7 @@
> +usr/bin/idn2
> +#usr/include/idn2.h
> +#usr/lib/libidn2.la
> +#usr/lib/libidn2.so
> +usr/lib/libidn2.so.0
> +usr/lib/libidn2.so.0.4.0
> +#usr/lib/pkgconfig/libidn2.pc
> diff --git a/lfs/libidn2 b/lfs/libidn2
> new file mode 100644
> index 000000000..b0e51e1e9
> --- /dev/null
> +++ b/lfs/libidn2
> @@ -0,0 +1,82 @@
> +##########################################################################=
#####
> +#                                                                         =
    #
> +# IPFire.org - A linux based firewall                                     =
    #
> +# Copyright (C) 2007-2024  IPFire Team  <info(a)ipfire.org>               =
      #
> +#                                                                         =
    #
> +# This program is free software: you can redistribute it and/or modify    =
    #
> +# it under the terms of the GNU General Public License as published by    =
    #
> +# the Free Software Foundation, either version 3 of the License, or       =
    #
> +# (at your option) any later version.                                     =
    #
> +#                                                                         =
    #
> +# This program is distributed in the hope that it will be useful,         =
    #
> +# but WITHOUT ANY WARRANTY; without even the implied warranty of          =
    #
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the           =
    #
> +# GNU General Public License for more details.                            =
    #
> +#                                                                         =
    #
> +# You should have received a copy of the GNU General Public License       =
    #
> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.   =
    #
> +#                                                                         =
    #
> +##########################################################################=
#####
> +
> +##########################################################################=
#####
> +# Definitions
> +##########################################################################=
#####
> +
> +include Config
> +
> +VER        =3D 2.3.7
> +
> +THISAPP    =3D libidn2-$(VER)
> +DL_FILE    =3D $(THISAPP).tar.gz
> +DL_FROM    =3D $(URL_IPFIRE)
> +DIR_APP    =3D $(DIR_SRC)/$(THISAPP)
> +TARGET     =3D $(DIR_INFO)/$(THISAPP)
> +
> +##########################################################################=
#####
> +# Top-level Rules
> +##########################################################################=
#####
> +
> +objects =3D $(DL_FILE)
> +
> +$(DL_FILE) =3D $(DL_FROM)/$(DL_FILE)
> +
> +$(DL_FILE)_BLAKE2 =3D 40fde88e6be1e4665738855608a65c949834728463a3fb466192=
403f1076e99f7d399b9631308ff6776a28915251a0136ddfe6a67e8e010c7ccdb7fc64125d39
> +
> +
> +install : $(TARGET)
> +
> +check : $(patsubst %,$(DIR_CHK)/%,$(objects))
> +
> +download :$(patsubst %,$(DIR_DL)/%,$(objects))
> +
> +b2 : $(subst %,%_BLAKE2,$(objects))
> +
> +##########################################################################=
#####
> +# Downloading, checking, b2sum
> +##########################################################################=
#####
> +
> +$(patsubst %,$(DIR_CHK)/%,$(objects)) :
> + @$(CHECK)
> +
> +$(patsubst %,$(DIR_DL)/%,$(objects)) :
> + @$(LOAD)
> +
> +$(subst %,%_BLAKE2,$(objects)) :
> + @$(B2SUM)
> +
> +##########################################################################=
#####
> +# Installation Details
> +##########################################################################=
#####
> +
> +$(TARGET) : $(patsubst %,$(DIR_DL)/%,$(objects))
> + @$(PREBUILD)
> + @rm -rf $(DIR_APP) && cd $(DIR_SRC) && tar axf $(DIR_DL)/$(DL_FILE)
> + cd $(DIR_APP) && ./configure \
> + --prefix=3D/usr \
> + --disable-nls \
> + --disable-doc \
> + --disable-static
> + cd $(DIR_APP) && make $(MAKETUNING)
> + cd $(DIR_APP) && make install
> + @rm -rf $(DIR_APP)
> + @$(POSTBUILD)
> diff --git a/make.sh b/make.sh
> index 35a602f62..9092b8da9 100755
> --- a/make.sh
> +++ b/make.sh
> @@ -1659,6 +1659,7 @@ build_system() {
> lfsmake2 libnet
> lfsmake2 libnl-3
> lfsmake2 libidn
> + lfsmake2 libidn2
> lfsmake2 nasm
> lfsmake2 libjpeg
> lfsmake2 openjpeg
> --=20
> 2.47.0
>=20


--===============9157960133617452484==--